Update compose to use published images #2801
Conversation
|
Please update the docs to specify how to use the "local" dev container for modelscan. |
PE39806
left a comment
There was a problem hiding this comment.
Since the current compose.prod.yaml builds the images differently to compose.override.yaml (the multistage build has a different layer target), I think we need another compose file for the pulled images as otherwise this PR would remove that true-to-prod "local" build which is useful for testing. Perhaps a compose.release.yaml would be a good place to have the pulled images?
I'm not 100% sure on these thoughts so any discussion is very welcome.
|
Another thought - we still need some way to test functionality via GitHub Actions which currently uses the local build for all images in |
JR40159
left a comment
There was a problem hiding this comment.
It would be good to discuss the pros/cons of this. Using a local build for the docker compose files can be very useful for local development.
90af20c to
4956b8a
Compare
|
I've rebased the branch and updated docs/tags based on comments above, but would probably be best to talk through the changes re testing/CICD etc. |
4d3475f to
672ca7c
Compare
3ecd545 to
8b63470
Compare
Updated the base compose file to use the published modelscan image since most of the time that should be the default. If you're developing the modelscan container, you can just add
-f compose.modelscan.yamlto tell compose it should build and use that image.By default, docker compose up/build/pull will use the published modelscan image, and the 'local' dev containers for frontend/backend.
If you add
-f compose.modelscan.yamlit will also use the 'local' dev container for modelscan.I also updated the prod compose file to reference the (current) published images for frontend/backend.
This also fixes the current main revision where if you do
compose pullit will not find the bailo containers (understandably), and should instead say 'skipped'.