Exclude expired activities#17
Merged
gboudreau merged 1 commit intogboudreau:maingboudreau/ws-api-python:mainfrom Nov 2, 2025
Merged
Exclude expired activities#17gboudreau merged 1 commit intogboudreau:maingboudreau/ws-api-python:mainfrom
gboudreau merged 1 commit intogboudreau:maingboudreau/ws-api-python:mainfrom
Conversation
gboudreau
added a commit
to gboudreau/ws-api-php
that referenced
this pull request
Nov 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While trying to pull a wider range, I found another thing that perhaps should be excluded.
When a limit-order is created and it doesn't finish within the day, and the expiration time is after market hours, the status for that transaction/activity seems to be set as 'EXPIRED'
I just added the below snippet to include that in.
note: Still using python 3.13, so if the syntax is for some reason not agreeing with python 3, then I am not able to see on my side. Not too sure how to downgrade either.