chore: quality-tightening (yarn 1 -> 4, oxfmt + oxlint + tsc + vitest + husky)#110
Merged
frostebite merged 4 commits intomaingame-ci/unity-activate:mainfrom May 6, 2026
Merged
chore: quality-tightening (yarn 1 -> 4, oxfmt + oxlint + tsc + vitest + husky)#110frostebite merged 4 commits intomaingame-ci/unity-activate:mainfrom
frostebite merged 4 commits intomaingame-ci/unity-activate:mainfrom
Conversation
… + husky) Yarn 1 -> 4 migration plus the standard quality-tightening rollout. - Drops yarn 1 lockfile + .yarnrc; adds .yarnrc.yml + mise.toml (node 20.18.0, yarn 4.14.1, actionlint, shellcheck, gitleaks). - prettier -> oxfmt - eslint (with @typescript-eslint, github, jest, prettier, unicorn) -> oxlint with eslint-plugin-unicorn - jest 26 + jest-circus + ts-jest + @types/jest -> vitest 4 + vite 7 + @vitest/coverage-istanbul (jest.config.js removed) - new: tsgo --noEmit (alongside tsc fallback) - husky 7 -> husky 9 with scripts/ensure-husky.mjs self-heal + lint-staged - new: gitleaks, actionlint, shellcheck as mise-managed binaries - TypeScript bumped 4.x -> 5; tsconfig target ES6 -> ES2022 + lib ES2022 + DOM, skipLibCheck on, types: [node]. Test migration (6 files): - Bulk-converted jest.* -> vi.* and added vitest imports. Workflow + action.yml updates: - actions/checkout@v3 -> @v4 across main.yml. - actions/setup-node@v3 -> @v4 with node-version 12.x -> 20.x. - action.yml runs.using 'node12' -> 'node20' (node12 is end-of-life on GitHub Actions and was already an actionlint error). Verified locally: lint 0/5, format clean, typecheck clean, test 21/23 (2 pre-existing skipped), build succeeds, actionlint clean across both workflows.
Add the standard yarn 4 .gitignore entries so we don't commit the zip cache + install-state.gz.
|
Warning Rate limit exceeded
To keep reviews running without waiting, you can enable usage-based add-on for your organization. This allows additional reviews beyond the hourly cap. Account admins can enable it under billing. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (5)
📒 Files selected for processing (25)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…ce undici >=6.24 Snyk flagged 9 transitive vulnerabilities (3 high, 6 moderate) through the old toolchain. Bumps: - @actions/github@2.2.0 -> 6.0.1 - @octokit/core@3.5.1 -> 6.1.5 Both bumps are upstream-recommended (Snyk auto-PR #107 was waiting for the same change). The undici resolution forces the upstream package to pull a fixed version that addresses: - undici WebSocket permessage-deflate unbounded memory consumption - undici WebSocket invalid server_max_window_bits unhandled exception After: 'yarn npm audit --recursive' reports no audit suggestions. Also: lint-staged globs now exclude dist/ explicitly so pre-commit hooks don't fail when the only staged files are in the dist/ ignore-patterned tree (e.g. after a yarn build that touches dist/index.js + sourcemap).
frostebite
approved these changes
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Yarn 1 \u2192 4 migration plus the standard quality-tightening rollout.
Yarn 1 \u2192 4
yarn.lock+.yarnrc; adds.yarnrc.yml+mise.toml(node 20.18.0, yarn 4.14.1, actionlint, shellcheck, gitleaks).packageManager: yarn@4.14.1in package.json.Quality stack
scripts/ensure-husky.mjsself-heal + lint-stagedTest migration (6 files)
Bulk-converted
jest.*\u2192vi.*and added vitest imports. 21 / 23 tests pass (2 pre-existing skipped).Workflow + action.yml updates
actions/checkout@v3\u2192@v4across main.yml.actions/setup-node@v3\u2192@v4with node-version 12.x \u2192 20.x.runs.using'node12'\u2192'node20'(node12 is end-of-life on GitHub Actions and was already an actionlint error).Verified locally
yarn lint\u2014 0 errors, 5 warningsyarn format:check\u2014 cleanyarn typecheck\u2014 cleanyarn test\u2014 21 / 23 (2 pre-existing skipped)yarn build\u2014 succeeds (ncc bundle 961kB, identical structure)actionlint\u2014 clean across both workflows