Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

In fmt master, basic_format_string has moved from base.h to xchar.h #3202

Copy link
Copy link
@pratikpc

Description

@pratikpc
Issue body actions

Took place in this commit

This change causes compile time errors due to:-

  1. Using SPDLOG_FMT_EXTERNAL and using fmt master
  2. spdlog/common needing basic_format_string without SPDLOG_USE_STD_FORMAT
    #ifndef SPDLOG_USE_STD_FORMAT
    template <typename T, typename... Args>
    inline fmt::basic_string_view<T> to_string_view(fmt::basic_format_string<T, Args...> fmt) {
    return fmt;
  3. xchar.h not being included due to absence of the specified definitions
    #if defined(SPDLOG_WCHAR_FILENAMES) || defined(SPDLOG_WCHAR_TO_UTF8_SUPPORT)
    #include <spdlog/fmt/xchar.h>
    #endif
Reactions are currently unavailable

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      Morty Proxy This is a proxified and sanitized view of the page, visit original site.