Skip to content

Navigation Menu

Sign in

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

refactor(curriculum): remove after-user-code bookmark lab #60406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
Loading
from
Open

refactor(curriculum): remove after-user-code bookmark lab #60406

wants to merge 2 commits into from

Conversation

a2937
Copy link
Member

@a2937 a2937 commented May 16, 2025

Checklist:

Ref: #57107

Because it is functioning the exact same way it was before I made my changes, I believe it is working.

@github-actions github-actions bot added the scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory. label May 16, 2025
@moT01
Copy link
Member

moT01 commented May 16, 2025

Something is maybe off a bit, want to take a look at the failing tests when you can @a2937? thanks

@moT01 moT01 added the status: waiting update To be applied to PR if a maintainer/reviewer has left a feedback and follow up is needed from OP label May 16, 2025
@a2937
Copy link
Member Author

a2937 commented May 16, 2025

getBookmarks is not defined that's a pretty huge issue and I'm not sure how to fix it.

@ilenia-magoni
Copy link
Contributor

ilenia-magoni commented May 16, 2025 •
edited
Loading

You should figure out where that error comes from, there can be an other error hidden behind it that makes the lines that define the function not execute

if you consider thet --before-all-- is executed before the editor code/the solution that can be an issue. You can't just take --after-user-code-- and put it in --before-all--

@gikf gikf added status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. and removed status: waiting update To be applied to PR if a maintainer/reviewer has left a feedback and follow up is needed from OP labels May 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory. status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@a2937 @moT01 @ilenia-magoni @gikf
Morty Proxy This is a proxified and sanitized view of the page, visit original site.