Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

chore(curriculum): add slice-and-splice to full-stack-curriculum #60265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 7 commits into
base: main
Choose a base branch
Loading
from
Open

chore(curriculum): add slice-and-splice to full-stack-curriculum #60265

wants to merge 7 commits into from

Conversation

ilenia-magoni
Copy link
Contributor

Checklist:

Closes freeCodeCamp/CurriculumExpansion#782

@ilenia-magoni ilenia-magoni requested a review from a team as a code owner May 10, 2025 08:03
@ilenia-magoni ilenia-magoni added status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory. full stack cert This label is for the new full stack certification labels May 10, 2025
@github-actions github-actions bot added platform: learn UI side of the client application that needs familiarity with React, Gatsby etc. scope: i18n language translation/internationalization. Often combined with language type label labels May 10, 2025
@ilenia-magoni ilenia-magoni changed the title chore: add slice-and-splice to full-stack-curriculum chore(curriculum): add slice-and-splice to full-stack-curriculum May 12, 2025
Ksound22
Ksound22 reviewed May 14, 2025
View reviewed changes
client/i18n/locales/english/intro.json Outdated Show resolved Hide resolved
Ksound22
Ksound22 reviewed May 14, 2025
View reviewed changes
Copy link
Member

@Ksound22 Ksound22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks neat 👍🏾

I only had two comments

@ilenia-magoni @Ksound22
Update client/i18n/locales/english/intro.json
113046a 
Co-authored-by: Kolade Chris <65571316+Ksound22@users.noreply.github.com>
moT01
moT01 reviewed May 14, 2025
View reviewed changes
Copy link
Member

@moT01 moT01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Left a few minor comments. Thought maybe we should come up with a new function name instead of frankenSplice - but it works.

...challenges/english/25-front-end-development/lab-slice-and-splice/579e2a2c335b9d72dd32e05c.md Outdated Show resolved Hide resolved
curriculum/challenges/_meta/lab-slice-and-splice/meta.json Show resolved Hide resolved
@moT01
Copy link
Member

moT01 commented May 21, 2025

Left a few comments, lgtm other than those.

@zairahira zairahira added status: waiting update To be applied to PR if a maintainer/reviewer has left a feedback and follow up is needed from OP and removed status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. labels May 22, 2025
@huyenltnguyen huyenltnguyen added the status: merge conflict To be applied to PR's that have a merge conflict and need updating label May 22, 2025
ilenia-magoni and others added 2 commits May 28, 2025 17:44
@ilenia-magoni @moT01
Apply suggestions from code review
9af0081 
Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>
@ilenia-magoni
Merge branch 'main' into feat/slice-and-splice
c6b7c4a
@ilenia-magoni ilenia-magoni added status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. and removed status: waiting update To be applied to PR if a maintainer/reviewer has left a feedback and follow up is needed from OP status: merge conflict To be applied to PR's that have a merge conflict and need updating labels May 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moT01 moT01 moT01 left review comments

@Ksound22 Ksound22 Ksound22 approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
full stack cert This label is for the new full stack certification platform: learn UI side of the client application that needs familiarity with React, Gatsby etc. scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory. scope: i18n language translation/internationalization. Often combined with language type label status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Convert slice and splice challenge to lab and add to main repo
5 participants
@ilenia-magoni @moT01 @Ksound22 @huyenltnguyen @zairahira
Morty Proxy This is a proxified and sanitized view of the page, visit original site.