Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

feat: implemented initialization of evm_opts and env in TestRunnerCon… #10542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: master
Choose a base branch
Loading
from
Open

feat: implemented initialization of evm_opts and env in TestRunnerCon… #10542

wants to merge 3 commits into from

Conversation

MozirDmitriy
Copy link
Contributor

…fig and their use in configure_executor

Motivation

TODO

Solution

  • Updated evm_opts and env fields in reconfigure_with method based on new configuration (Config), which allows to correctly apply inline-config and update EVM environment.
  • The configure_executor method now explicitly applies env and evm_opts to the Executor: environment, gas limit, create2_deployer and other parameters are set.
  • Removed the TODO comments associated with these fields and implemented the actual logic.
  • This ensures that the test runner works correctly when changing the configuration on the fly and eliminates possible inconsistencies between the settings and the state of the EVM.

PR Checklist

  • Added Tests
  • Added Documentation
  • Breaking changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DaniPopes DaniPopes Awaiting requested review from DaniPopes DaniPopes is a code owner

@klkvr klkvr Awaiting requested review from klkvr klkvr is a code owner

@mattsse mattsse Awaiting requested review from mattsse mattsse is a code owner

@grandizzy grandizzy Awaiting requested review from grandizzy grandizzy is a code owner

@yash-atreya yash-atreya Awaiting requested review from yash-atreya yash-atreya is a code owner

@zerosnacks zerosnacks Awaiting requested review from zerosnacks zerosnacks is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
Foundry
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@MozirDmitriy
Morty Proxy This is a proxified and sanitized view of the page, visit original site.