Adds HF equivalency tests for Mistral#505
Open
flaviabeo wants to merge 8 commits intofoundation-model-stack:mainfoundation-model-stack/foundation-model-stack:mainfrom
flaviabeo:mistral_eq_hfflaviabeo/foundation-model-stack:mistral_eq_hfCopy head branch name to clipboard
Open
Adds HF equivalency tests for Mistral#505flaviabeo wants to merge 8 commits intofoundation-model-stack:mainfoundation-model-stack/foundation-model-stack:mainfrom flaviabeo:mistral_eq_hfflaviabeo/foundation-model-stack:mistral_eq_hfCopy head branch name to clipboard
flaviabeo wants to merge 8 commits intofoundation-model-stack:mainfoundation-model-stack/foundation-model-stack:mainfrom
flaviabeo:mistral_eq_hfflaviabeo/foundation-model-stack:mistral_eq_hfCopy head branch name to clipboard
Conversation
Signed-off-by: Flavia Beo <flavia.beo@ibm.com>
Signed-off-by: Flavia Beo <flavia.beo@ibm.com>
Signed-off-by: Flavia Beo <flavia.beo@ibm.com>
Signed-off-by: Flavia Beo <flavia.beo@ibm.com>
Signed-off-by: Flavia Beo <flavia.beo@ibm.com>
Signed-off-by: Flavia Beo <flavia.beo@ibm.com>
Signed-off-by: Flavia Beo <flavia.beo@ibm.com>
|
|
||
| ratio2 = SequenceMatcher(None, output_batch[1], output_text2).ratio() | ||
|
|
||
| assert ratio2 > 0.8, f"text 2 incorrect - \n{output_batch[1]}\n{output_text2}" |
Contributor
There was a problem hiding this comment.
Thank you for for adding these! Do the inputs currently diverge for greedy decoding? Curious about the ratio vs just matching the outputs directly
Collaborator
Author
There was a problem hiding this comment.
Yes, it's not an exact match. So assert equal always fails - These models are like a piece of the original one, with fewer heads and smaller. This way they don't produce anything so meaningful, and then when compared to the adapter one, it is not outputting fully the same texts. I thought of loosening this comparison, but please let me know your thoughts on this!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.