feat: added revision kwargs parameters to get model from hugging face#468
Open
wallashss wants to merge 2 commits intofoundation-model-stack:mainfoundation-model-stack/foundation-model-stack:mainfrom
Open
feat: added revision kwargs parameters to get model from hugging face#468wallashss wants to merge 2 commits intofoundation-model-stack:mainfoundation-model-stack/foundation-model-stack:mainfrom
wallashss wants to merge 2 commits intofoundation-model-stack:mainfoundation-model-stack/foundation-model-stack:mainfrom
Conversation
JRosenkranz
reviewed
Sep 15, 2025
fms/models/hf/utils.py
Outdated
| def _infer_model_configuration( | ||
| model_id_or_path: str | os.PathLike, | ||
| download_weights: bool = True, | ||
| revision: str = None, |
Collaborator
There was a problem hiding this comment.
type hint here should be Optional[str]
JRosenkranz
reviewed
Sep 15, 2025
fms/models/hf/utils.py
Outdated
| checkpoint_sharding: Optional[str] = None, | ||
| group: Optional[ProcessGroup] = None, | ||
| initialize_model_with_weights: bool = True, | ||
| revision: str = None |
Collaborator
There was a problem hiding this comment.
type hint should be Optional[str]
8999124 to
0c38146
Compare
Signed-off-by: Wallas Santos <wallashss@ibm.com>
0c38146 to
3565862
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the support to set revision as kwargs on get_model or as_fms_model.