Conversation
Signed-off-by: Antoni Viros i Martin <aviros@ibm.com>
JRosenkranz
requested changes
Sep 15, 2025
Signed-off-by: Antoni Viros i Martin <aviros@ibm.com>
Signed-off-by: Antoni Viros i Martin <aviros@ibm.com>
Signed-off-by: Antoni Viros i Martin <aviros@ibm.com>
JRosenkranz
reviewed
Sep 18, 2025
JRosenkranz
reviewed
Sep 18, 2025
| position_ids = ((~is_pad).cumsum(1) - 1).clamp(min=0) | ||
| if position_ids is None: | ||
| position_ids = ((~is_pad).cumsum(1) - 1).clamp(min=0) | ||
| else: |
Collaborator
There was a problem hiding this comment.
is this the bert case?
Collaborator
Author
There was a problem hiding this comment.
yes, this is the BERT case
JRosenkranz
reviewed
Sep 18, 2025
JRosenkranz
reviewed
Sep 18, 2025
| head_bias: bool = True, | ||
| dropout: float = 0.0, | ||
| do_pooling: bool = False, | ||
| apply_pooling_fn: bool = False, |
Collaborator
There was a problem hiding this comment.
why are we removing this?
Collaborator
Author
There was a problem hiding this comment.
trying to fully match both BERT adn roberta code in HF, which was a mess
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Needed for fine-tuning, and some other testing going on.
Still needs a full HF checkpoint adapter inference.