fix get_signature so that it no longer ignores some optional params#413
Merged
JRosenkranz merged 2 commits intomainfoundation-model-stack/foundation-model-stack:mainfrom May 29, 2025
get_signature_fixfoundation-model-stack/foundation-model-stack:get_signature_fixCopy head branch name to clipboard
Merged
fix get_signature so that it no longer ignores some optional params#413JRosenkranz merged 2 commits intomainfoundation-model-stack/foundation-model-stack:mainfrom get_signature_fixfoundation-model-stack/foundation-model-stack:get_signature_fixCopy head branch name to clipboard
JRosenkranz merged 2 commits intomainfoundation-model-stack/foundation-model-stack:mainfrom
get_signature_fixfoundation-model-stack/foundation-model-stack:get_signature_fixCopy head branch name to clipboard
Conversation
… as they will be part of attn_kwargs Signed-off-by: Joshua Rosenkranz <jmrosenk@us.ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the latest attn_kwargs change, we no longer need to remove parameters to pass from option_params passed to get_signature as attn_kwargs will catch these