Remove custom exception handling#117
Merged
orangecms merged 1 commit intofossasia:developmentfossasia/pslab-python:developmentfrom Jun 13, 2020
Merged
Remove custom exception handling#117orangecms merged 1 commit intofossasia:developmentfossasia/pslab-python:developmentfrom
orangecms merged 1 commit intofossasia:developmentfossasia/pslab-python:developmentfrom
Conversation
Collaborator
Author
|
The Codacy quality issues are not really related to the changes introduces by this PR. I'd rather fix them in a separate PR at a later point. |
CloudyPadmal
approved these changes
Jun 8, 2020
orangecms
approved these changes
Jun 13, 2020
Contributor
Looks like that came with #118. Should be fixed later. :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the custom exception handling discussed in #115. It should not affect normal operation (with one exception, see below).
Additionally, it changes the behavior of ScienceLab.write_bulk_flash() by changing the indentation level if this block:
In the current version, this block will never be executed because it comes after a
raisestatement. This does not seem intentional, so I fixed it. I have not tested it, but since it does not write anything to the hardware it should be safe.My IDE also autoremoved some trailing whitespace here and there throughout the code.