Handle conflict in namespace 'serial'#114
Merged
mariobehling merged 1 commit intofossasia:developmentfossasia/pslab-python:developmentfrom Jun 7, 2020
Merged
Handle conflict in namespace 'serial'#114mariobehling merged 1 commit intofossasia:developmentfossasia/pslab-python:developmentfrom
mariobehling merged 1 commit intofossasia:developmentfossasia/pslab-python:developmentfrom
Conversation
CloudyPadmal
approved these changes
May 24, 2020
mariobehling
approved these changes
Jun 7, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The packages 'pyserial' and 'serial' both use the 'serial' namespace. Therefore,
import serialwill succeed if the user has the latter package installed, even though PSL needs the former. This results in an unhelpful "Could not connect" RuntimeError down the line.With this change, PSL verifies that the correct 'serial' was imported, and complains otherwise.