Week2 #9
Open
Week2 #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattiaslundberg
requested changes
Sep 1, 2019
Collaborator
mattiaslundberg
left a comment
There was a problem hiding this comment.
Promises part looks good! Missing some thing regarding css (especially on mobile), that's a requirement to pass week 2 so please have a look at it!
Let me know if you need any assistance!
| xhr.onerror = () => cb(new Error('Network request failed')); | ||
| xhr.send(); | ||
| function fetchJSON(url) { | ||
| return new Promise((resolve, reject) => { |
| fetchJSON(url, (err, data) => { | ||
| const root = document.getElementById('root'); | ||
| if (err) { | ||
| function renderContributors(contributors, contributorsContainer) { |
Collaborator
There was a problem hiding this comment.
Nice naming of the function and arguments!
|
|
||
| <body> | ||
| <div id="root"></div> | ||
| <header> |
Collaborator
There was a problem hiding this comment.
Why wrapping the entire app in <header>, it seems only parts of the app should be in header?
| align-items: flex-start; | ||
| justify-content: center; | ||
| } | ||
| @media screen and (max-width: 768px) { |
Collaborator
There was a problem hiding this comment.
I don't think this works, did you try it?
| margin: 10px; | ||
| } | ||
| header { | ||
| width: 800px; |
Collaborator
There was a problem hiding this comment.
It's usually not a good idea to hard-code a specific width, try to display as a fraction of the avaliable space instead. It breaks on mobile :/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.