Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit f9c8259

Browse filesBrowse files
[flutter_releases] Flutter Dev 2.3.0-12.1.pre Framework Cherrypicks (flutter#82852)
* enable uwp embedding in dev * add tests
1 parent 0f03147 commit f9c8259
Copy full SHA for f9c8259

File tree

Expand file treeCollapse file tree

2 files changed

+17
-0
lines changed
Filter options
Expand file treeCollapse file tree

2 files changed

+17
-0
lines changed

‎packages/flutter_tools/lib/src/features.dart

Copy file name to clipboardExpand all lines: packages/flutter_tools/lib/src/features.dart
+4Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -301,6 +301,10 @@ const Feature windowsUwpEmbedding = Feature(
301301
available: true,
302302
enabledByDefault: false,
303303
),
304+
dev: FeatureChannelSetting(
305+
available: true,
306+
enabledByDefault: false,
307+
),
304308
);
305309

306310
/// A [Feature] is a process for conditionally enabling tool features.

‎packages/flutter_tools/test/general.shard/features_test.dart

Copy file name to clipboardExpand all lines: packages/flutter_tools/test/general.shard/features_test.dart
+13Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -467,6 +467,19 @@ void main() {
467467
expect(featureFlags.isWindowsUwpEnabled, true);
468468
});
469469

470+
testWithoutContext('Flutter Windows UWP desktop off by default on dev', () {
471+
final FeatureFlags featureFlags = createFlags('dev');
472+
473+
expect(featureFlags.isWindowsUwpEnabled, false);
474+
});
475+
476+
testWithoutContext('Flutter Windows UWP desktop enabled with config on dev', () {
477+
final FeatureFlags featureFlags = createFlags('dev');
478+
testConfig.setValue('enable-windows-uwp-desktop', true);
479+
480+
expect(featureFlags.isWindowsUwpEnabled, true);
481+
});
482+
470483
testWithoutContext('Flutter Windows UWP desktop off by default on stable', () {
471484
final FeatureFlags featureFlags = createFlags('stable');
472485

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.