self review

flutter · auto-submit · May 23, 2025 · May 16, 2025 · May 16, 2025 · May 19, 2025
commit 5b8f2cea3e0e9c5841751a06b43da9d82c5c4b22
@@ -30,13 +30,13 @@ public ProxyApiRegistrar getPigeonRegistrar() {
  @NonNull
  @Override
  public PendingRecording withAudioEnabled(PendingRecording pigeonInstance, boolean initialMuted) {
-    if (!initialMuted) {
-      if (ContextCompat.checkSelfPermission(
-              getPigeonRegistrar().getContext(), Manifest.permission.RECORD_AUDIO)
-          == PackageManager.PERMISSION_GRANTED) {
-        return pigeonInstance.withAudioEnabled(false);
-      }
+    if (!initialMuted
+        && ContextCompat.checkSelfPermission(
+                getPigeonRegistrar().getContext(), Manifest.permission.RECORD_AUDIO)
+            == PackageManager.PERMISSION_GRANTED) {
+      return pigeonInstance.withAudioEnabled(false);
    }
+
    return pigeonInstance.withAudioEnabled(true);
  }


@@ -71,7 +71,7 @@ public void withAudioEnabled_doesNotEnableAudioWhenRequestedAndPermissionNotGran
  }

  @Test
-  public void withAudioEnabled_doesNotEnableAudioWhenNotRequested() {
+  public void withAudioEnabled_doesNotEnableAudioWhenAudioNotRequested() {
    final PigeonApiPendingRecording api =
        new TestProxyApiRegistrar().getPigeonApiPendingRecording();
    final PendingRecording instance = mock(PendingRecording.class);

@@ -261,7 +261,8 @@ class AndroidCameraCameraX extends CameraPlatform {
  /// This is expressed in terms of one of the [Surface] rotation constant.
  late int _initialDefaultDisplayRotation;

-  /// Whether or not audio should attempt to be enabled for recording video.
+  /// Whether or not audio should be enabled for recording video if permission is
+  /// granted.
  @visibleForTesting
  late bool enableRecordingAudio;

@@ -1108,7 +1109,9 @@ class AndroidCameraCameraX extends CameraPlatform {
    );
    pendingRecording = await recorder!.prepareRecording(videoOutputPath!);

-    // Attempt to enable/disable recording audio as requested.
+    // Enable/disable recording audio as requested. If enabling audio is requested
+    // and permission was not granted when the camera was created, then recording
+    // audio will be disabled to respect the denied permission.
    pendingRecording =
        await pendingRecording!.withAudioEnabled(enableRecordingAudio);


@@ -518,7 +518,7 @@ abstract class VideoRecordEventListener {
  ),
 )
 abstract class PendingRecording {
-  /// Enables audio to be recorded for this recording.
+  /// Enables/disables audio to be recorded for this recording.
  PendingRecording withAudioEnabled(bool initialMuted);

  /// Starts the recording, making it an active recording.
-Original file line number
+Diff line change
@@ -30,13 +30,13 @@ public ProxyApiRegistrar getPigeonRegistrar() {
       @NonNull
       @Override
       public PendingRecording withAudioEnabled(PendingRecording pigeonInstance, boolean initialMuted) {
             Copy link

  
      
    
  

  
      

  
    Contributor


      

  

  
    
      

      
            bparrishMines
  

      

      

      


        May 21, 2025


      
    

  


        
      
  
  
  
    

    There was a problem hiding this comment.


  

 
  
    

    Choose a reason for hiding this comment

    
      The reason will be displayed to describe this comment to others. Learn more.
    

    
      
      


  


  
    
      Just to clarify, withAudioEnabled(true) disables audio and withAudioEnabled(false) enables audio? I'm confused by the parameter name being initialMuted.
    
  
  


    

        
      
  
  
    
  
  
  
    
    Sorry, something went wrong.
  

  
    
  
    
      

              Uh oh!

              
There was an error while loading. Please reload this page.


  
  


          
      
  
    
    
      
        
            
    All reactions
  


          
          
        
      
    

    



    
        
  
    
        
    
  


      
          
  
      
            Copy link

  
      
    
  

  
      

  
    Contributor


      

  Author


  

  
    
      

      
            camsim99
  

      

      

      


        May 21, 2025


      
    

  


        
      
  
  
  
    

    There was a problem hiding this comment.


  

 
  
    

    Choose a reason for hiding this comment

    
      The reason will be displayed to describe this comment to others. Learn more.
    

    
      
      


  


  
    
      Lol yeah it's confusing.
I made this mirror PendingRecording.withAudioEnabled where initialMuted == true means that you want to initialize the recording as being muted/audio disabled, so withAudioEnabled(true) disables audio, withAudioEnabled(false) enables audio.
    
  
  


    

        
      
  
  
    
  
  
  
    
    Sorry, something went wrong.
  

  
    
  
    
      

              Uh oh!

              
There was an error while loading. Please reload this page.


  
  


          
      
  
    
    
            bparrishMines reacted with thumbs up emoji
      
        
            
    All reactions
  


          
              
                👍
                  1 reaction
-        if (!initialMuted) {
-          if (ContextCompat.checkSelfPermission(
-                  getPigeonRegistrar().getContext(), Manifest.permission.RECORD_AUDIO)
-              == PackageManager.PERMISSION_GRANTED) {
-            return pigeonInstance.withAudioEnabled(false);
-          }
+        if (!initialMuted
+            && ContextCompat.checkSelfPermission(
+                    getPigeonRegistrar().getContext(), Manifest.permission.RECORD_AUDIO)
+                == PackageManager.PERMISSION_GRANTED) {
+          return pigeonInstance.withAudioEnabled(false);
         }
         return pigeonInstance.withAudioEnabled(true);
       }
-          Expand Down