-
Notifications
You must be signed in to change notification settings - Fork 28.7k
Fix infinite loop in CupertinoSliverNavigationBar collapse animation by adding bounds check for target scroll position #170210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
…by adding bounds check for target scroll position
…ionBar collapse animation
It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
@victorsanni, could you please take a look at this once you have a chance? 🙏 I'm not really sure why the Mac_arm64 and Mac_x64 "tool_test_commands" tests are failing. 🤷 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with a nit. Thanks for the fix.
Co-authored-by: Victor Sanni <victorsanniay@gmail.com>
…animation-infinite-loop
…animation-infinite-loop
…animation-infinite-loop
…animation-infinite-loop
This pull request includes a fix to the
CupertinoSliverNavigationBarState
class in thenav_bar.dart
file. The change ensures that theanimateTo
method is only called when thetarget
is within the valid scroll extent range, i.e.target <= position.maxScrollExtent
.Fixes #164458
Pre-launch Checklist
///
).