Fix infinite loop in CupertinoSliverNavigationBar collapse animation by adding bounds check for target scroll position #170210
Conversation
…by adding bounds check for target scroll position
…ionBar collapse animation
|
It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
|
@victorsanni, could you please take a look at this once you have a chance? 🙏 I'm not really sure why the Mac_arm64 and Mac_x64 "tool_test_commands" tests are failing. 🤷 |
Co-authored-by: Victor Sanni <victorsanniay@gmail.com>
…animation-infinite-loop
…animation-infinite-loop
…animation-infinite-loop
…animation-infinite-loop
…animation-infinite-loop
…animation-infinite-loop
…animation-infinite-loop
|
@MitchellGoodwin @victorsanni how likely is it for this fix to make it into a CP? |
This pull request includes a fix to the
CupertinoSliverNavigationBarStateclass in thenav_bar.dartfile. The change ensures that theanimateTomethod is only called when thetargetis within the valid scroll extent range, i.e.target <= position.maxScrollExtent.Fixes #164458
Pre-launch Checklist
///).