Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Add Drag Sensitivity to RefreshIndicator #170170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 12 commits into
base: master
Choose a base branch
Loading
from
Open

Add Drag Sensitivity to RefreshIndicator #170170

wants to merge 12 commits into from
+198 −3

Conversation

AcarFurkan
Copy link
Contributor

@AcarFurkan AcarFurkan commented Jun 6, 2025 •
edited
Loading

Drag Sensitivity Feature:
Added a new dragSensitivity parameter to the RefreshIndicator, allowing developers to customize the amount of drag required to trigger a refresh. This feature provides greater control over the user experience, especially in applications where the default sensitivity may not be ideal.

Example Update:
Updated the refresh_indicator.0.dart example to demonstrate the new dragSensitivity parameter. The example now includes a sensitivity setting of 0.7, showcasing how this adjustment affects the refresh behavior.
List which issues are fixed by this PR. You must list at least one issue. An issue is not required if the PR fixes something trivial like a typo.

Fixes #147363

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • I followed the [breaking change policy] and added [Data Driven Fixes] where supported.
  • All existing and new tests are passing.

@github-actions github-actions bot added framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. f: scrolling Viewports, list views, slivers, etc. d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos labels Jun 6, 2025
@AcarFurkan
Copy link
Contributor Author

Hey @Piinks :)
I saw that this PR was closed, but our company is experiencing the same issue.
I applied a similar solution and added tests as well. What do you think?

@dkwingsmt dkwingsmt self-requested a review June 11, 2025 18:32
@dkwingsmt
Copy link
Contributor

Thanks for picking up the PR! As part of the review, have you observed similar options or customizations in other Android apps? Just wanting to know how this should be customized.

@dkwingsmt
Copy link
Contributor

dkwingsmt commented Jun 25, 2025 •
edited
Loading

Sorry for the late review. So this PR is meant to fix #147363, but I don't think it really fixes the core problem. The target issue was due to the fact that nesting scroll views leads to a huge containerExtent for not being bounded by the view. In fact, #147961 looks the correct fix to me, which unfortunately wasn't finished.

Can you explain why you chose this approach instead continuing the approach used in #147961 ?

(Other than that, this PR looks pretty good as a PR that simply wants to add a dragSensitivity property, but then this addition isn't done to fix any existing problem, AFAIK.)

@AcarFurkan
Copy link
Contributor Author

Hey @dkwingsmt, thanks for the review!

In the implementation at this PR, the sensitivity wasn’t consistent across different screen sizes it behaved differently on large and small screens.

@dkwingsmt
Copy link
Contributor

Yeah I can see that. But the problem is that your approach doesn't solve this problem automatically either, since the user has to assign a sensitivity, which is even more tedious because it is a factor on the full extent. I would imagine that the common value would be to use the full extent of the outmost scroll view. Do you think so? And if so, do you think if there's a way to acquire and apply that value?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dkwingsmt dkwingsmt Awaiting requested review from dkwingsmt

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos f: material design flutter/packages/flutter/material repository. f: scrolling Viewports, list views, slivers, etc. framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

NestedScrollView with RefreshIndicator: dragging effect of RefreshIndicator seems to disappear with a slight drag
2 participants
@AcarFurkan @dkwingsmt
Morty Proxy This is a proxified and sanitized view of the page, visit original site.