Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Rename entryPointBaseUrl to entrypointBaseUrl #170166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
Loading
from
Open

Conversation

piedcipher
Copy link
Member

@piedcipher piedcipher commented Jun 6, 2025

Closes #168968

Need to change here as well - https://github.com/flutter/website/blob/main/src/content/platform-integration/web/initialization.md

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group.

@github-actions github-actions bot added engine flutter/engine repository. See also e: labels. platform-web Web applications specifically labels Jun 6, 2025
@piedcipher
Copy link
Member Author

piedcipher commented Jun 6, 2025

Trying to figure what kind of test to write.

Also for rename fixes like this we have data driven fix in dart but for this, will it be a breaking change?

@piedcipher piedcipher requested a review from mdebbar June 6, 2025 18:52
Copy link
Contributor

@mdebbar mdebbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a public API, so renaming it will be a breaking change, yes.

Ideally, we would support both names for some time, and print a deprecation warning when someone uses the old name. And later, we can remove the old name.

cc @eyebrowsoffire

@mdebbar mdebbar requested a review from eyebrowsoffire June 9, 2025 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
engine flutter/engine repository. See also e: labels. platform-web Web applications specifically
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inconsistent case style for parameter 'entrypoint'
2 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.