[stable] disable vivante from using impeller gles/vulkan #170132
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My first cherry pick, I want to see this vivante fix (#169760) on stable to avoid disabling impeller for devices with a vivante graphics chip.
Impacted Users
I have no exact numbers but such Android devices with a vivante graphics chip
Impact Description
The app crashes on startup. See the issue #167850 for details
Workaround
Option 1: Disable impeller
Disable impeller by adding this to the
AndroidManifest.xml
, as explained in the documentation.Option 2: Just for that chip
Add this to your
MainActivitiy
:Risk
I see no risks
Test Coverage
I tested it on such a device
Validation Steps
Grep e.g. a Wanzl Fastlaner (German link, didn't find an English link) and run it there