Limit Dialog max width to 560dp per Material Design spec #170065
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
| constraints ?? | ||
| dialogTheme.constraints ?? | ||
| const BoxConstraints(minWidth: 280.0, maxWidth: 560.0); |
There was a problem hiding this comment.
maxWidth and minWidth should be extracted to a const with a proper name.
| @@ -1339,7 +1336,7 @@ class SimpleDialog extends StatelessWidget { | ||
| Widget dialogChild = IntrinsicWidth( | ||
| stepWidth: 56.0, | ||
| child: ConstrainedBox( | ||
| constraints: const BoxConstraints(minWidth: 280.0), | ||
| constraints: const BoxConstraints(minWidth: 280.0, maxWidth: 560.0), |
There was a problem hiding this comment.
maxWidth and minWidth should be extracted to a const with a proper name.
Summary
This PR enforces a maximum width of 560dp on the
Dialogwidget as per the Material Design 3 specification. The limitation is applied both:ConstrainedBox(used in thebuildmethod),IntrinsicWidthlayout block (to prevent internal content from expanding beyond the expected width).Why This Change?
According to the Material guidelines:
Without a
maxWidthconstraint, Dialogs on large screens (like tablets or desktops) may grow excessively wide.Changes
_kDialogMaxWidth = 560.0.boxConstraints.ConstrainedBoxwrapped byIntrinsicWidth.Related Issue
Fixes: #163709
Let me know if this constraint should be conditional on
useMaterial3, or if platform-specific logic is preferred.