fix(cupertino): adjust CupertinoCheckbox padding on macOS #170063
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
| ..side = effectiveBorderSide | ||
| ..brightness = CupertinoTheme.of(context).brightness, | ||
| child: Padding( | ||
| padding: effectivePadding, |
There was a problem hiding this comment.
I don't think the problem in the issue is the padding, rather the size (kMinInteractiveDimensionCupertino).
| @@ -421,34 +421,41 @@ class _CupertinoCheckboxState extends State<CupertinoCheckbox> | ||
| ? SystemMouseCursors.click | ||
| : SystemMouseCursors.basic); | ||
| }); | ||
| final isMac = defaultTargetPlatform == TargetPlatform.macOS; |
There was a problem hiding this comment.
Instead of a boolean, use a switch statement to enumerate all platforms and set the needed size.
fix(cupertino): adjust CupertinoCheckbox padding on macOS
Previously, CupertinoCheckbox used iOS-style padding across all platforms,
which caused excessive spacing in macOS apps. This commit adds platform-specific
padding: tighter padding for macOS, while preserving the current default for others.
Fixes #165140