-
Notifications
You must be signed in to change notification settings - Fork 28.7k
Reverts "Data assets (#169273)" #170034
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
auto-submit
merged 1 commit into
master
from
revert_da95aca671fdd0eb47ad71095abbf1e4f167b7dd
Jun 4, 2025
Merged
Reverts "Data assets (#169273)" #170034
auto-submit
merged 1 commit into
master
from
revert_da95aca671fdd0eb47ad71095abbf1e4f167b7dd
Jun 4, 2025
+592
−1,806
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit da95aca.
fluttergithubbot
approved these changes
Jun 4, 2025
9 tasks
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 5, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 5, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 5, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 5, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 5, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 5, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 5, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
a: desktop
Running on desktop
revert of
Bot Only: Tracking label for bot. Tracks new revert of pull requests.
team-ios
Owned by iOS platform team
tool
Affects the "flutter" command-line tool. See also t: labels.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts: #169273
Initiated by: jason-simmons
Reason for reverting: seeing flakes of
dart_data_asset_test.dart
CI runs for various PRs got errors in the
tool_integration_tests
shards. The errors occurred on multiple platforms (Linux, Mac, and Windows).Affected PRs include: #170022, #169995
LUCI log of an error:
https://ci.chromium.org/ui/p/flutter/builders/try/Windows%20t
Original PR Author: mosuem
Reviewed By: {bkonyi}
This change reverts the following previous change:
Refiling of #164094, which itself is a rebase of #159675
This PR adds bundling support for the experimental dart data asset feature: Dart packages with hooks can now emit data assets which the flutter tool will bundle.
It relies on flutter's existing asset bundling mechanism (e.g. entries in AssetManifest.json, DevFS syncing in reload/restart, ...).
The support is added under an experimental flag (similar to the existing native assets experimental flag).
Also, kNativeAssets is removed to also bundle data assets on flutter build bundle.
The chrome sandbox is disabled as per #165664.
Pre-launch Checklist
///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.