[ Tool ] Remove support for Android x86 targets #169884

bkonyi · Jun 2, 2025

Dart x86 is deprecated, no longer shipped, and will eventually be removed from the Dart VM. This PR removes the last remaining x86 target, android-x86, from the tool.

Work towards #157543 and #160932

Dart x86 is deprecated, no longer shipped, and will eventually be removed from the Dart VM. This PR removes the last remaining x86 target, android-x86, from the tool. Work towards #157543

…upport

matanlurey · Jun 2, 2025

 "android-x86" is not an allowed value for option "--target-platform".
 Run 'flutter -h' (or 'flutter <command> -h') for available flutter commands and options.

a-siva · Jun 2, 2025

dev/devicelab/bin/tasks/gradle_plugin_fat_apk_test.dart

@@ -27,15 +27,13 @@ Future<void> main() async {
          ...baseApkFiles,
          'lib/armeabi-v7a/libflutter.so',
          'lib/arm64-v8a/libflutter.so',
-          // Debug mode intentionally includes `x86` and `x86_64`.
-          'lib/x86/libflutter.so',
+          // Debug mode intentionally includes `x86_64`.


Not sure what this comment is supposed to mean ?

This was mostly a mechanical update, so I'm not sure either... 😅 it can probably be removed.

bkonyi · Jun 2, 2025

 "android-x86" is not an allowed value for option "--target-platform".
 Run 'flutter -h' (or 'flutter <command> -h') for available flutter commands and options.

Do you happen to know where Linux firebase_release_smoke_test lives @matanlurey? I couldn't find anything in flutter/flutter

matanlurey · Jun 2, 2025

Let me take a look

matanlurey · Jun 2, 2025

Looks like it is here:

flutter/.ci.yaml

Lines 628 to 657 in a79827a

    
             - name: Linux firebase_release_smoke_test 
        
               recipe: firebaselab/firebaselab 
        
               timeout: 60 
        
               properties: 
        
                 dependencies: >- 
        
                   [ 
        
                     {"dependency": "android_sdk", "version": "version:36v1"}, 
        
                     {"dependency": "open_jdk", "version": "version:21"} 
        
                   ] 
        
                 tags: > 
        
                   ["firebaselab"] 
        
                 task_name: release_smoke_test 
        
                 physical_devices: >- 
        
                   [ 
        
                     "--device", "model=shiba,version=34", 
        
                     "--device", "model=redfin,version=30", 
        
                     "--device", "model=griffin,version=24" 
        
                   ] 
        
                 # TODO(flutter/flutter#123331): This device is flaking. 
        
                 # "--device", "model=Nexus6P,version=25" 
        
                 virtual_devices: >- 
        
                   [ 
        
                     "--device", "model=Nexus5.gce_x86,version=21", 
        
                     "--device", "model=Nexus5.gce_x86,version=22", 
        
                     "--device", "model=Nexus5.gce_x86,version=23", 
        
                     "--device", "model=Nexus6P,version=25", 
        
                     "--device", "model=Nexus6P,version=26", 
        
                     "--device", "model=Nexus6P,version=27", 
        
                     "--device", "model=NexusLowRes,version=29" 
        
                   ]

And runs a custom recipe.

bkonyi · Jun 2, 2025

Looks like it is here:

flutter/.ci.yaml

Lines 628 to 657 in a79827a

- name: Linux firebase_release_smoke_test

recipe: firebaselab/firebaselab

timeout: 60

properties:

dependencies: >-

[

{"dependency": "android_sdk", "version": "version:36v1"},

{"dependency": "open_jdk", "version": "version:21"}

]

tags: >

["firebaselab"]

task_name: release_smoke_test

physical_devices: >-

[

"--device", "model=shiba,version=34",

"--device", "model=redfin,version=30",

"--device", "model=griffin,version=24"

]

# TODO(flutter/flutter#123331): This device is flaking.

# "--device", "model=Nexus6P,version=25"

virtual_devices: >-

[

"--device", "model=Nexus5.gce_x86,version=21",

"--device", "model=Nexus5.gce_x86,version=22",

"--device", "model=Nexus5.gce_x86,version=23",

"--device", "model=Nexus6P,version=25",

"--device", "model=Nexus6P,version=26",

"--device", "model=Nexus6P,version=27",

"--device", "model=NexusLowRes,version=29"

]

And runs a custom recipe.

I did come across that, but it's not clear what's actually being run. --target-platform=android-x86 is coming from somewhere... 😞

matanlurey · Jun 2, 2025

Oh, I found it. I'll send you a recipes CL.

matanlurey · Jun 2, 2025

https://flutter-review.googlesource.com/c/recipes/+/66160

bkonyi · Jun 3, 2025

https://flutter-review.googlesource.com/c/recipes/+/66160

Thanks Matan!

…utter#169884)

[ Tool ] Remove support for Android x86 targets

f6c2939

Dart x86 is deprecated, no longer shipped, and will eventually be removed from the Dart VM. This PR removes the last remaining x86 target, android-x86, from the tool. Work towards #157543

bkonyi requested a review from a-siva June 2, 2025 20:19

github-actions bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Jun 2, 2025

bkonyi added 2 commits June 2, 2025 16:20

Merge branch 'master' of github.com:flutter/flutter into remove_x86_s…

a39e35d

…upport

Remove x86 expectations from some failing tests

59f5a4c

bkonyi requested a review from matanlurey June 2, 2025 22:42

bkonyi marked this pull request as ready for review June 2, 2025 22:42

matanlurey approved these changes Jun 2, 2025

View reviewed changes

a-siva approved these changes Jun 2, 2025

View reviewed changes

bkonyi mentioned this pull request Jun 3, 2025

Undismissable "Android x86 targets" warning on flutter build apk #160932

Closed

Merge branch 'master' into remove_x86_support

7c20a3c

bkonyi added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 4, 2025

auto-submit bot added this pull request to the merge queue Jun 4, 2025

Merged via the queue into master with commit c46d410 Jun 4, 2025
156 checks passed

auto-submit bot deleted the remove_x86_support branch June 4, 2025 01:27

flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jun 4, 2025

engine-flutter-autoroll mentioned this pull request Jun 4, 2025

Roll Flutter from 0e536eb9fe4b to d966d99b680a (127 revisions) flutter/packages#9374

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 4, 2025

c46d4102a [ Tool ] Remove support for Android x86 targets (flutter/fl…

988dff1

…utter#169884)

engine-flutter-autoroll mentioned this pull request Jun 4, 2025

Roll Flutter from 0e536eb9fe4b to 0c0406a6158e (128 revisions) flutter/packages#9375

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 4, 2025

c46d4102a [ Tool ] Remove support for Android x86 targets (flutter/fl…

cb62ecf

…utter#169884)

engine-flutter-autoroll mentioned this pull request Jun 4, 2025

Roll Flutter from 0e536eb9fe4b to 99a5b3fb4ec6 (129 revisions) flutter/packages#9376

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 4, 2025

c46d4102a [ Tool ] Remove support for Android x86 targets (flutter/fl…

ebc3550

…utter#169884)

engine-flutter-autoroll mentioned this pull request Jun 4, 2025

Roll Flutter from 0e536eb9fe4b to 1fcd888704ea (130 revisions) flutter/packages#9377

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 4, 2025

c46d4102a [ Tool ] Remove support for Android x86 targets (flutter/fl…

b78f7c5

…utter#169884)

engine-flutter-autoroll mentioned this pull request Jun 4, 2025

Roll Flutter from 0e536eb9fe4b to 1fcd888704ea (130 revisions) flutter/packages#9378

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 4, 2025

c46d4102a [ Tool ] Remove support for Android x86 targets (flutter/fl…

1307a86

…utter#169884)

engine-flutter-autoroll mentioned this pull request Jun 5, 2025

Roll Flutter from 0e536eb9fe4b to 6e738ee3929f (144 revisions) flutter/packages#9381

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2025

c46d4102a [ Tool ] Remove support for Android x86 targets (flutter/fl…

1f62dc6

…utter#169884)

engine-flutter-autoroll mentioned this pull request Jun 5, 2025

Roll Flutter from 0e536eb9fe4b to 121caa68d6c1 (145 revisions) flutter/packages#9382

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2025

c46d4102a [ Tool ] Remove support for Android x86 targets (flutter/fl…

fac400b

…utter#169884)

engine-flutter-autoroll mentioned this pull request Jun 5, 2025

Roll Flutter from 0e536eb9fe4b to 736053538b14 (146 revisions) flutter/packages#9383

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2025

c46d4102a [ Tool ] Remove support for Android x86 targets (flutter/fl…

a3a9a68

…utter#169884)

engine-flutter-autoroll mentioned this pull request Jun 5, 2025

Roll Flutter from 0e536eb9fe4b to 817fa9701467 (147 revisions) flutter/packages#9384

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2025

c46d4102a [ Tool ] Remove support for Android x86 targets (flutter/fl…

957adf7

…utter#169884)

engine-flutter-autoroll mentioned this pull request Jun 5, 2025

Roll Flutter from 0e536eb9fe4b to 92c55f06e01e (148 revisions) flutter/packages#9385

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2025

c46d4102a [ Tool ] Remove support for Android x86 targets (flutter/fl…

c6694c0

…utter#169884)

engine-flutter-autoroll mentioned this pull request Jun 5, 2025

Roll Flutter from 0e536eb9fe4b to 4469c5e4db3e (149 revisions) flutter/packages#9386

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2025

c46d4102a [ Tool ] Remove support for Android x86 targets (flutter/fl…

89b3a4e

…utter#169884)

engine-flutter-autoroll mentioned this pull request Jun 5, 2025

Roll Flutter from 0e536eb9fe4b to 63980cb25ba5 (150 revisions) flutter/packages#9388

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2025

c46d4102a [ Tool ] Remove support for Android x86 targets (flutter/fl…

4c6fb6c

…utter#169884)

engine-flutter-autoroll mentioned this pull request Jun 5, 2025

Roll Flutter from 0e536eb9fe4b to 7f26571eb13a (151 revisions) flutter/packages#9390

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2025

c46d4102a [ Tool ] Remove support for Android x86 targets (flutter/fl…

da6667f

…utter#169884)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[ Tool ] Remove support for Android x86 targets #169884

[ Tool ] Remove support for Android x86 targets #169884

bkonyi commented Jun 2, 2025 •

edited

Loading

Uh oh!

matanlurey commented Jun 2, 2025

Uh oh!

a-siva Jun 2, 2025

Uh oh!

bkonyi Jun 2, 2025

Uh oh!

bkonyi commented Jun 2, 2025

Uh oh!

matanlurey commented Jun 2, 2025

Uh oh!

matanlurey commented Jun 2, 2025

Uh oh!

bkonyi commented Jun 2, 2025

Uh oh!

matanlurey commented Jun 2, 2025

Uh oh!

matanlurey commented Jun 2, 2025

Uh oh!

bkonyi commented Jun 3, 2025

Uh oh!

Uh oh!

Uh oh!

Search code, repositories, users, issues, pull requests...

[ Tool ] Remove support for Android x86 targets #169884

[ Tool ] Remove support for Android x86 targets #169884

Conversation

bkonyi commented Jun 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

matanlurey commented Jun 2, 2025

Uh oh!

a-siva Jun 2, 2025

Choose a reason for hiding this comment

Uh oh!

bkonyi Jun 2, 2025

Choose a reason for hiding this comment

Uh oh!

bkonyi commented Jun 2, 2025

Uh oh!

matanlurey commented Jun 2, 2025

Uh oh!

matanlurey commented Jun 2, 2025

Uh oh!

bkonyi commented Jun 2, 2025

Uh oh!

matanlurey commented Jun 2, 2025

Uh oh!

matanlurey commented Jun 2, 2025

Uh oh!

bkonyi commented Jun 3, 2025

Uh oh!

Uh oh!

Uh oh!

bkonyi commented Jun 2, 2025 •

edited

Loading