Remove deprecated Objective-C iOS app create template #169547
Conversation
| @@ -212,7 +212,7 @@ void main() { | ||
| workflow: 'create', | ||
| commandHasTerminal: false, | ||
| createAndroidLanguage: 'java', | ||
| createIosLanguage: 'objc', | ||
| createIosLanguage: 'swift', |
There was a problem hiding this comment.
Keep the createIosLanguage usage data to check when -t plugin usages becomes low enough to remove that too.
| @@ -1761,91 +1726,7 @@ void main() { | ||
| }, | ||
| ); | ||
|
|
||
| testUsingContext( | ||
| 'Correct info.plist key-value pairs for swift iOS module.', |
There was a problem hiding this comment.
This test was redundant, iOS modules are only supported for Objective-C.
| @@ -1,121 +0,0 @@ | ||
| <?xml version="1.0" encoding="UTF-8"?> |
There was a problem hiding this comment.
Odd we had an Objective-C and Swift version of schemes, they were identical except for a single BlueprintIdentifier.
d8e1c03 to
f52fb00
Compare
| ); | ||
| }); | ||
|
|
||
| section('Build Objective-C application with Swift and Objective-C plugins as libraries'); | ||
| section('Build iOS application with Swift and Objective-C plugins as frameworks'); |
There was a problem hiding this comment.
This diff is confusing, but I removed the Build Objective-C application with Swift and Objective-C plugins as libraries and Build Objective-C application with Swift and Objective-C plugins as frameworks sections, and renamed Build Swift iOS application with Swift and Objective-C plugins as frameworks to remove "Swift".
| @@ -3185,34 +3064,6 @@ void main() { | ||
| overrides: <Type, Generator>{FeatureFlags: () => TestFeatureFlags(), Logger: () => logger}, | ||
| ); | ||
|
|
||
| testUsingContext( | ||
| 'plugin includes native Objective-C unit tests', |
There was a problem hiding this comment.
Optional: instead of deleting this, you could rename it "Obj-C plugin includes native Swift unit tests" and adjust the expectations accordingly.
But it also wouldn't really matter if a feature I think almost nobody but us uses regresses for a deprecated flag, so I'm fine with axing it.
| ); | ||
| if (stringArg('ios-language') == 'objc') { | ||
| globals.printWarning( | ||
| 'Please comment in https://github.com/flutter/flutter/issues/148586 describing your use-case for using Objective-C instead of Swift.', |
There was a problem hiding this comment.
This will need an update per #148586 (comment)
There was a problem hiding this comment.
(It's interesting that the warning has been in stable for (I think; I didn't check branch alignment) 5 months now, and we haven't had any comments so far.)
There was a problem hiding this comment.
Updated the link.
I suppose it wasn't a very beloved feature. I checked again and in the last 3 months the Obj-C app creation is ~1%.
Remove Objective-C template for new apps. Existing apps won't be impacted.
Keep Objective-C templates for plugins, though their example apps will be Swift instead. See #148586 (comment)
Move
templates/app/ios-swift.tmpltotemplates/app/ios.tmpl.Fixes #148586
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.