Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

fix[widget_inspector]: Widget Inspector Directionality & Move button tooltip. #169425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

muhammadkamel
Copy link
Contributor

@muhammadkamel muhammadkamel commented May 25, 2025

Fix Widget Inspector buttons direction & arrow button tooltip text on when the App locale is RTL:

Before:
before_1
before_2

After:
after_en1
after_en2
after_ar1
after_ar2

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group.

@github-actions github-actions bot added the framework flutter/packages/flutter repository. See also f: labels. label May 25, 2025
@muhammadkamel
Copy link
Contributor Author

@Piinks
I'd appreciate it if you could review this PR.

@muhammadkamel muhammadkamel changed the title fix[widget_inspector]: Widget Inspector Directionality & move button … fix[widget_inspector]: Widget Inspector Directionality & Move button tooltip. May 25, 2025
@muhammadkamel
Copy link
Contributor Author

@srawlins

Could you please review this?

@srawlins
Copy link
Contributor

I am not qualified to review here. CC @elliette

@Piinks Piinks requested a review from elliette May 29, 2025 15:25
Copy link
Member

@elliette elliette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this PR! And my apologies for missing the RTL directionality in the original implementation.

A few small changes but overall LGTM!

packages/flutter/lib/src/widgets/widget_inspector.dart Outdated Show resolved Hide resolved
packages/flutter/test/widgets/widget_inspector_test.dart Outdated Show resolved Hide resolved
@muhammadkamel
Copy link
Contributor Author

Thank you for this PR! And my apologies for missing the RTL directionality in the original implementation.

A few small changes but overall LGTM!

You're welcome :)

Could you please check now

packages/flutter/lib/src/widgets/widget_inspector.dart Outdated Show resolved Hide resolved
packages/flutter/lib/src/widgets/widget_inspector.dart Outdated Show resolved Hide resolved
packages/flutter/lib/src/widgets/widget_inspector.dart Outdated Show resolved Hide resolved
Copy link
Member

@elliette elliette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few more requests but this is looking good, thank you!

@github-actions github-actions bot added f: material design flutter/packages/flutter/material repository. f: cupertino flutter/packages/flutter/cupertino repository labels May 30, 2025
@muhammadkamel
Copy link
Contributor Author

@elliette

Could you check again now 💯

packages/flutter/lib/src/widgets/widget_inspector.dart Outdated Show resolved Hide resolved
@kenzieschmoll
Copy link
Member

One more comment, then LGTM.

Update comments

Co-authored-by: Kenzie Davisson <43759233+kenzieschmoll@users.noreply.github.com>
@muhammadkamel
Copy link
Contributor Author

@kenzieschmoll
Could you please check now?
Thank you! :)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 4, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 4, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 4, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 4, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 4, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
f: cupertino flutter/packages/flutter/cupertino repository f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.