Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Updated AVD dependencies for linux_android_emu for Android 16 #169121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 11 commits into
base: master
Choose a base branch
Loading
from

Conversation

jesswrd
Copy link
Contributor

@jesswrd jesswrd commented May 20, 2025

Experimented with and monitored for flakiness using a 36 emulator for linux_android_emu_unstable. After >= 200 commits, it looks like this test target is stable. Since we have confirmed the 36 emulator for linux_android_emu_unstable is stable, we can update the linux_android_emu to use the same emulator.

Update: Ran into API 36 emulator issue where multiple platform view modes fail here that breaks integration tests under the android_engine_vulkan_tests test target. To continue with the Android 16 AVD update, the android_engine_vulkan_tests test target is now using configurations from the newly created platform property linux_android_emu_vulkan_stable, which is configured to use an API 35 AVD. linux_android_emu is updated to use a API 36 AVD. All test targets using the linux_android_emu platform property configurations will use an API 36 AVD.

Partially Addresses #163071

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@jesswrd jesswrd changed the title Updating AVD dependency for linux_android_emu Updated AVD dependency for linux_android_emu for Android 16 May 20, 2025
@jesswrd jesswrd marked this pull request as ready for review May 22, 2025 09:21
@jesswrd jesswrd requested a review from reidbaker May 22, 2025 09:21
@reidbaker
Copy link
Contributor

@reidbaker reidbaker added the autosubmit Merge PR when tree becomes green via auto submit App label May 28, 2025
Copy link
Contributor

auto-submit bot commented May 28, 2025

autosubmit label was removed for flutter/flutter/169121, because - The status or check suite Linux_android_emu android_engine_vulkan_tests has failed. Please fix the issues identified (or deflake) before re-applying this label.

@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label May 28, 2025
@reidbaker reidbaker added the autosubmit Merge PR when tree becomes green via auto submit App label May 29, 2025
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label May 29, 2025
Copy link
Contributor

auto-submit bot commented May 29, 2025

autosubmit label was removed for flutter/flutter/169121, because - The status or check suite Linux_android_emu android_engine_vulkan_tests has failed. Please fix the issues identified (or deflake) before re-applying this label.

@flutter-dashboard
Copy link

Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change).

If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Changes reported for pull request #169121 at sha 0737dd8

@flutter-dashboard flutter-dashboard bot added the will affect goldens Changes to golden files label Jun 4, 2025
@jesswrd jesswrd changed the title Updated AVD dependency for linux_android_emu for Android 16 Updated AVD dependencies for linux_android_emu for Android 16 Jun 4, 2025
@jesswrd jesswrd requested a review from reidbaker June 5, 2025 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
will affect goldens Changes to golden files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.