[Engine][Web] Fixed fallback font loading process #166212
Conversation
c79856c to
89bba24
Compare
engine/src/flutter/lib/web_ui/lib/src/engine/font_fallbacks.dart
Outdated
Show resolved
Hide resolved
|
Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change). If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review. For more guidance, visit Writing a golden file test for Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
Co-authored-by: Mouad Debbar <mouad.debbar@gmail.com>
|
Golden file changes are available for triage from new commit, Click here to view. For more guidance, visit Writing a golden file test for Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
@koji-1009 here's the screenshot that was generated by the new golden test:
It looks like your "after" screenshot. Could you please confirm that it looks right so I can approve it? |
|
@mdebbar |
|
autosubmit label was removed for flutter/flutter/166212, because This PR has not met approval requirements for merging. The PR author is not a member of flutter-hackers and needs 1 more review(s) in order to merge this PR.
|
| @@ -100,6 +103,41 @@ void testMain() { | ||
| // TODO(hterkelsen): https://github.com/flutter/flutter/issues/71520 | ||
| }); | ||
|
|
||
| test('will download Noto Sans JP if Japanease text is added in ja', () async { |
There was a problem hiding this comment.
nit: Japanease -> Japanese
There was a problem hiding this comment.
Sorry! I fixed. 3786aba
fix #165299
Fixes a problem where the drawing does not render as expected if the value of
maxCodePointsCoveredis greater for an unsuitable language than for a font suitable for that language.Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.