Closed
Description
Looks like it macOS 15.5 caused some differences in goldens:
- https://flutter-gold.skia.org/detail?grouping=name%3Dengine.impeller_Play_AiksTest_CanRenderDifferentShapesWithSameColorSource_Metal%26source_type%3Dflutter&digest=773ea5d3a6dc8e54633daf94b3961b2e
- https://flutter-gold.skia.org/detail?grouping=name%3Dengine.impeller_Play_AiksTest_ImageColorSourceEffectTransform_Metal%26source_type%3Dflutter&digest=8fb984052789015374b8259ea278f4f4
- https://flutter-gold.skia.org/detail?grouping=name%3Dengine.impeller_Play_AiksTest_CoordinateConversionsAreCorrect_Metal%26source_type%3Dflutter&digest=be4df5c1db726d93e58b3c5d4f8e8add
- https://flutter-gold.skia.org/detail?grouping=name%3Dengine.impeller_Play_AiksTest_DrawAdvancedBlendPartlyOffscreen_OpenGLES%26source_type%3Dflutter&digest=665f613c79e86e339ff86d15d950c1b4
- https://flutter-gold.skia.org/detail?grouping=name%3Dengine.impeller_Play_AiksTest_DrawAdvancedBlendPartlyOffscreen_Metal%26source_type%3Dflutter&digest=0fc0aaf8dc3239130aad7396c9e2f4a8
https://cr-buildbucket.appspot.com/build/8712853365764407665:
Running command "/Volumes/Work/s/w/ir/cache/builder/engine/src/out/ci/mac_release_arm64_tests/dart-sdk/bin/dart bin/golden_tests_harvester.dart /Volumes/Work/s/w/ir/x/t/impeller_goldenhw3btb_i" in "None"
Failed to add image to Skia Gold: Error when running Skia Gold: /Volumes/Work/s/w/ir/cache/gold/goldctl imgtest add --work-dir /Volumes/Work/s/w/ir/x/t/impeller_goldenhw3btb_i/temp --test-name engine.impeller_Play_AiksTest_CanRenderDifferentShapesWithSameColorSource_Metal --png-file /Volumes/Work/s/w/ir/x/t/impeller_goldenhw3btb_i/impeller_Play_AiksTest_CanRenderDifferentShapesWithSameColorSource_Metal.png --passfail --add-test-optional-key image_matching_algorithm:fuzzy --add-test-optional-key fuzzy_max_different_pixels:7864 --add-test-optional-key fuzzy_pixel_delta_threshold:8
Skia Gold received an unapproved image in post-submit
testing. Golden file images in flutter/engine are triaged
in pre-submit during code review for the given PR.
Visit https://flutter-gold.skia.org// to view and approve
the image(s), or revert the associated change. For more
information, visit the wiki:
https://github.com/flutter/flutter/wiki/Writing-a-golden-file-test-for-package:flutter
stdout: Given image with hash 773ea5d3a6dc8e54633daf94b3961b2e for test engine.impeller_Play_AiksTest_CanRenderDifferentShapesWithSameColorSource_Metal
Expectation for test: dc50e34abac690a2972a873789044a2f (positive)
Fetching most recent positive digest for trace with ID "8012f3dc4d663a831acac4d548f9d9e6".
Non-exact image comparison using algorithm "fuzzy" against most recent positive digest "dc50e34abac690a2972a873789044a2f".
Untriaged or negative image: https://flutter-gold.skia.org/detail?grouping=name%3Dengine.impeller_Play_AiksTest_CanRenderDifferentShapesWithSameColorSource_Metal%26source_type%3Dflutter&digest=773ea5d3a6dc8e54633daf94b3961b2e
stderr: Test: engine.impeller_Play_AiksTest_CanRenderDifferentShapesWithSameColorSource_Metal FAIL
Failed to add image to Skia Gold: Error when running Skia Gold: /Volumes/Work/s/w/ir/cache/gold/goldctl imgtest add --work-dir /Volumes/Work/s/w/ir/x/t/impeller_goldenhw3btb_i/temp --test-name engine.impeller_Play_AiksTest_ImageColorSourceEffectTransform_Metal --png-file /Volumes/Work/s/w/ir/x/t/impeller_goldenhw3btb_i/impeller_Play_AiksTest_ImageColorSourceEffectTransform_Metal.png --passfail --add-test-optional-key image_matching_algorithm:fuzzy --add-test-optional-key fuzzy_max_different_pixels:7864 --add-test-optional-key fuzzy_pixel_delta_threshold:8
Skia Gold received an unapproved image in post-submit
testing. Golden file images in flutter/engine are triaged
in pre-submit during code review for the given PR.
Visit https://flutter-gold.skia.org// to view and approve
the image(s), or revert the associated change. For more
information, visit the wiki:
https://github.com/flutter/flutter/wiki/Writing-a-golden-file-test-for-package:flutter
stdout: Given image with hash 8fb984052789015374b8259ea278f4f4 for test engine.impeller_Play_AiksTest_ImageColorSourceEffectTransform_Metal
Expectation for test: 9543c5f666db21d0584ce1fa32d18bc8 (positive)
Expectation for test: 974145d1868f842aae9101b9abe4a8ba (positive)
Fetching most recent positive digest for trace with ID "489392d0d6860fc33fa465bbf5d004b7".
Non-exact image comparison using algorithm "fuzzy" against most recent positive digest "974145d1868f842aae9101b9abe4a8ba".
Untriaged or negative image: https://flutter-gold.skia.org/detail?grouping=name%3Dengine.impeller_Play_AiksTest_ImageColorSourceEffectTransform_Metal%26source_type%3Dflutter&digest=8fb984052789015374b8259ea278f4f4
stderr: Test: engine.impeller_Play_AiksTest_ImageColorSourceEffectTransform_Metal FAIL
Failed to add image to Skia Gold: Error when running Skia Gold: /Volumes/Work/s/w/ir/cache/gold/goldctl imgtest add --work-dir /Volumes/Work/s/w/ir/x/t/impeller_goldenhw3btb_i/temp --test-name engine.impeller_Play_AiksTest_CoordinateConversionsAreCorrect_Metal --png-file /Volumes/Work/s/w/ir/x/t/impeller_goldenhw3btb_i/impeller_Play_AiksTest_CoordinateConversionsAreCorrect_Metal.png --passfail --add-test-optional-key image_matching_algorithm:fuzzy --add-test-optional-key fuzzy_max_different_pixels:7864 --add-test-optional-key fuzzy_pixel_delta_threshold:8
Skia Gold received an unapproved image in post-submit
testing. Golden file images in flutter/engine are triaged
in pre-submit during code review for the given PR.
Visit https://flutter-gold.skia.org// to view and approve
the image(s), or revert the associated change. For more
information, visit the wiki:
https://github.com/flutter/flutter/wiki/Writing-a-golden-file-test-for-package:flutter
stdout: Given image with hash be4df5c1db726d93e58b3c5d4f8e8add for test engine.impeller_Play_AiksTest_CoordinateConversionsAreCorrect_Metal
Expectation for test: 099c3bafd50d98bf5daf29e18224142e (positive)
Fetching most recent positive digest for trace with ID "86cf957cf461cd717e9909bcfe2e7fe5".
Non-exact image comparison using algorithm "fuzzy" against most recent positive digest "099c3bafd50d98bf5daf29e18224142e".
Untriaged or negative image: https://flutter-gold.skia.org/detail?grouping=name%3Dengine.impeller_Play_AiksTest_CoordinateConversionsAreCorrect_Metal%26source_type%3Dflutter&digest=be4df5c1db726d93e58b3c5d4f8e8add
stderr: Test: engine.impeller_Play_AiksTest_CoordinateConversionsAreCorrect_Metal FAIL
Failed to add image to Skia Gold: Error when running Skia Gold: /Volumes/Work/s/w/ir/cache/gold/goldctl imgtest add --work-dir /Volumes/Work/s/w/ir/x/t/impeller_goldenhw3btb_i/temp --test-name engine.impeller_Play_AiksTest_DrawAdvancedBlendPartlyOffscreen_OpenGLES --png-file /Volumes/Work/s/w/ir/x/t/impeller_goldenhw3btb_i/impeller_Play_AiksTest_DrawAdvancedBlendPartlyOffscreen_OpenGLES.png --passfail --add-test-optional-key image_matching_algorithm:fuzzy --add-test-optional-key fuzzy_max_different_pixels:7864 --add-test-optional-key fuzzy_pixel_delta_threshold:8
Skia Gold received an unapproved image in post-submit
testing. Golden file images in flutter/engine are triaged
in pre-submit during code review for the given PR.
Visit https://flutter-gold.skia.org// to view and approve
the image(s), or revert the associated change. For more
information, visit the wiki:
https://github.com/flutter/flutter/wiki/Writing-a-golden-file-test-for-package:flutter
stdout: Given image with hash 665f613c79e86e339ff86d15d950c1b4 for test engine.impeller_Play_AiksTest_DrawAdvancedBlendPartlyOffscreen_OpenGLES
Expectation for test: 24ef1e67b75f42bab1384097abcaf41c (positive)
Expectation for test: 457982c849e6ee4f7102beeee7b4f921 (positive)
Fetching most recent positive digest for trace with ID "46eb9eef1f9045ac05d5319d81d8874d".
Non-exact image comparison using algorithm "fuzzy" against most recent positive digest "457982c849e6ee4f7102beeee7b4f921".
Untriaged or negative image: https://flutter-gold.skia.org/detail?grouping=name%3Dengine.impeller_Play_AiksTest_DrawAdvancedBlendPartlyOffscreen_OpenGLES%26source_type%3Dflutter&digest=665f613c79e86e339ff86d15d950c1b4
stderr: Test: engine.impeller_Play_AiksTest_DrawAdvancedBlendPartlyOffscreen_OpenGLES FAIL
Failed to add image to Skia Gold: Error when running Skia Gold: /Volumes/Work/s/w/ir/cache/gold/goldctl imgtest add --work-dir /Volumes/Work/s/w/ir/x/t/impeller_goldenhw3btb_i/temp --test-name engine.impeller_Play_AiksTest_DrawAdvancedBlendPartlyOffscreen_Metal --png-file /Volumes/Work/s/w/ir/x/t/impeller_goldenhw3btb_i/impeller_Play_AiksTest_DrawAdvancedBlendPartlyOffscreen_Metal.png --passfail --add-test-optional-key image_matching_algorithm:fuzzy --add-test-optional-key fuzzy_max_different_pixels:7864 --add-test-optional-key fuzzy_pixel_delta_threshold:8
Skia Gold received an unapproved image in post-submit
testing. Golden file images in flutter/engine are triaged
in pre-submit during code review for the given PR.
Visit https://flutter-gold.skia.org// to view and approve
the image(s), or revert the associated change. For more
information, visit the wiki:
https://github.com/flutter/flutter/wiki/Writing-a-golden-file-test-for-package:flutter
stdout: Given image with hash 0fc0aaf8dc3239130aad7396c9e2f4a8 for test engine.impeller_Play_AiksTest_DrawAdvancedBlendPartlyOffscreen_Metal
Expectation for test: e2010d7b17e9fa191642e31c73724186 (positive)
Fetching most recent positive digest for trace with ID "e75115180d362d4de7423aeae77bef01".
Non-exact image comparison using algorithm "fuzzy" against most recent positive digest "e2010d7b17e9fa191642e31c73724186".
Untriaged or negative image: https://flutter-gold.skia.org/detail?grouping=name%3Dengine.impeller_Play_AiksTest_DrawAdvancedBlendPartlyOffscreen_Metal%26source_type%3Dflutter&digest=0fc0aaf8dc3239130aad7396c9e2f4a8
stderr: Test: engine.impeller_Play_AiksTest_DrawAdvancedBlendPartlyOffscreen_Metal FAIL
Unhandled exception:
Failed comparison: impeller_Play_AiksTest_CanRenderDifferentShapesWithSameColorSource_Metal.png
#0 harvest.<anonymous closure> (package:golden_tests_harvester/golden_tests_harvester.dart:191:11)
#1 _FutureListener.handleError (dart:async/future_impl.dart:243:22)
#2 Future._propagateToListeners.handleError (dart:async/future_impl.dart:960:47)
#3 Future._propagateToListeners (dart:async/future_impl.dart:981:13)
#4 Future._completeErrorObject (dart:async/future_impl.dart:738:5)
#5 Future._completeError (dart:async/future_impl.dart:742:5)
<asynchronous suspension>
!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
Failed Command:
/Volumes/Work/s/w/ir/cache/builder/engine/src/out/ci/mac_release_arm64_tests/dart-sdk/bin/dart bin/golden_tests_harvester.dart /Volumes/Work/s/w/ir/x/t/impeller_goldenhw3btb_i
Exit Code: 255
Output:
Failed to add image to Skia Gold: Error when running Skia Gold: /Volumes/Work/s/w/ir/cache/gold/goldctl imgtest add --work-dir /Volumes/Work/s/w/ir/x/t/impeller_goldenhw3btb_i/temp --test-name engine.impeller_Play_AiksTest_CanRenderDifferentShapesWithSameColorSource_Metal --png-file /Volumes/Work/s/w/ir/x/t/impeller_goldenhw3btb_i/impeller_Play_AiksTest_CanRenderDifferentShapesWithSameColorSource_Metal.png --passfail --add-test-optional-key image_matching_algorithm:fuzzy --add-test-optional-key fuzzy_max_different_pixels:7864 --add-test-optional-key fuzzy_pixel_delta_threshold:8
Skia Gold received an unapproved image in post-submit
testing. Golden file images in flutter/engine are triaged
in pre-submit during code review for the given PR.
Visit https://flutter-gold.skia.org// to view and approve
the image(s), or revert the associated change. For more
information, visit the wiki:
https://github.com/flutter/flutter/wiki/Writing-a-golden-file-test-for-package:flutter
stdout: Given image with hash 773ea5d3a6dc8e54633daf94b3961b2e for test engine.impeller_Play_AiksTest_CanRenderDifferentShapesWithSameColorSource_Metal
Expectation for test: dc50e34abac690a2972a873789044a2f (positive)
Fetching most recent positive digest for trace with ID "8012f3dc4d663a831acac4d548f9d9e6".
Non-exact image comparison using algorithm "fuzzy" against most recent positive digest "dc50e34abac690a2972a873789044a2f".
Untriaged or negative image: https://flutter-gold.skia.org/detail?grouping=name%3Dengine.impeller_Play_AiksTest_CanRenderDifferentShapesWithSameColorSource_Metal%26source_type%3Dflutter&digest=773ea5d3a6dc8e54633daf94b3961b2e
stderr: Test: engine.impeller_Play_AiksTest_CanRenderDifferentShapesWithSameColorSource_Metal FAIL
Failed to add image to Skia Gold: Error when running Skia Gold: /Volumes/Work/s/w/ir/cache/gold/goldctl imgtest add --work-dir /Volumes/Work/s/w/ir/x/t/impeller_goldenhw3btb_i/temp --test-name engine.impeller_Play_AiksTest_ImageColorSourceEffectTransform_Metal --png-file /Volumes/Work/s/w/ir/x/t/impeller_goldenhw3btb_i/impeller_Play_AiksTest_ImageColorSourceEffectTransform_Metal.png --passfail --add-test-optional-key image_matching_algorithm:fuzzy --add-test-optional-key fuzzy_max_different_pixels:7864 --add-test-optional-key fuzzy_pixel_delta_threshold:8
Skia Gold received an unapproved image in post-submit
testing. Golden file images in flutter/engine are triaged
in pre-submit during code review for the given PR.
Visit https://flutter-gold.skia.org// to view and approve
the image(s), or revert the associated change. For more
information, visit the wiki:
https://github.com/flutter/flutter/wiki/Writing-a-golden-file-test-for-package:flutter
stdout: Given image with hash 8fb984052789015374b8259ea278f4f4 for test engine.impeller_Play_AiksTest_ImageColorSourceEffectTransform_Metal
Expectation for test: 9543c5f666db21d0584ce1fa32d18bc8 (positive)
Expectation for test: 974145d1868f842aae9101b9abe4a8ba (positive)
Fetching most recent positive digest for trace with ID "489392d0d6860fc33fa465bbf5d004b7".
Non-exact image comparison using algorithm "fuzzy" against most recent positive digest "974145d1868f842aae9101b9abe4a8ba".
Untriaged or negative image: https://flutter-gold.skia.org/detail?grouping=name%3Dengine.impeller_Play_AiksTest_ImageColorSourceEffectTransform_Metal%26source_type%3Dflutter&digest=8fb984052789015374b8259ea278f4f4
stderr: Test: engine.impeller_Play_AiksTest_ImageColorSourceEffectTransform_Metal FAIL
Failed to add image to Skia Gold: Error when running Skia Gold: /Volumes/Work/s/w/ir/cache/gold/goldctl imgtest add --work-dir /Volumes/Work/s/w/ir/x/t/impeller_goldenhw3btb_i/temp --test-name engine.impeller_Play_AiksTest_CoordinateConversionsAreCorrect_Metal --png-file /Volumes/Work/s/w/ir/x/t/impeller_goldenhw3btb_i/impeller_Play_AiksTest_CoordinateConversionsAreCorrect_Metal.png --passfail --add-test-optional-key image_matching_algorithm:fuzzy --add-test-optional-key fuzzy_max_different_pixels:7864 --add-test-optional-key fuzzy_pixel_delta_threshold:8
Skia Gold received an unapproved image in post-submit
testing. Golden file images in flutter/engine are triaged
in pre-submit during code review for the given PR.
Visit https://flutter-gold.skia.org// to view and approve
the image(s), or revert the associated change. For more
information, visit the wiki:
https://github.com/flutter/flutter/wiki/Writing-a-golden-file-test-for-package:flutter
stdout: Given image with hash be4df5c1db726d93e58b3c5d4f8e8add for test engine.impeller_Play_AiksTest_CoordinateConversionsAreCorrect_Metal
Expectation for test: 099c3bafd50d98bf5daf29e18224142e (positive)
Fetching most recent positive digest for trace with ID "86cf957cf461cd717e9909bcfe2e7fe5".
Non-exact image comparison using algorithm "fuzzy" against most recent positive digest "099c3bafd50d98bf5daf29e18224142e".
Untriaged or negative image: https://flutter-gold.skia.org/detail?grouping=name%3Dengine.impeller_Play_AiksTest_CoordinateConversionsAreCorrect_Metal%26source_type%3Dflutter&digest=be4df5c1db726d93e58b3c5d4f8e8add
stderr: Test: engine.impeller_Play_AiksTest_CoordinateConversionsAreCorrect_Metal FAIL
Failed to add image to Skia Gold: Error when running Skia Gold: /Volumes/Work/s/w/ir/cache/gold/goldctl imgtest add --work-dir /Volumes/Work/s/w/ir/x/t/impeller_goldenhw3btb_i/temp --test-name engine.impeller_Play_AiksTest_DrawAdvancedBlendPartlyOffscreen_OpenGLES --png-file /Volumes/Work/s/w/ir/x/t/impeller_goldenhw3btb_i/impeller_Play_AiksTest_DrawAdvancedBlendPartlyOffscreen_OpenGLES.png --passfail --add-test-optional-key image_matching_algorithm:fuzzy --add-test-optional-key fuzzy_max_different_pixels:7864 --add-test-optional-key fuzzy_pixel_delta_threshold:8
Skia Gold received an unapproved image in post-submit
testing. Golden file images in flutter/engine are triaged
in pre-submit during code review for the given PR.
Visit https://flutter-gold.skia.org// to view and approve
the image(s), or revert the associated change. For more
information, visit the wiki:
https://github.com/flutter/flutter/wiki/Writing-a-golden-file-test-for-package:flutter
stdout: Given image with hash 665f613c79e86e339ff86d15d950c1b4 for test engine.impeller_Play_AiksTest_DrawAdvancedBlendPartlyOffscreen_OpenGLES
Expectation for test: 24ef1e67b75f42bab1384097abcaf41c (positive)
Expectation for test: 457982c849e6ee4f7102beeee7b4f921 (positive)
Fetching most recent positive digest for trace with ID "46eb9eef1f9045ac05d5319d81d8874d".
Non-exact image comparison using algorithm "fuzzy" against most recent positive digest "457982c849e6ee4f7102beeee7b4f921".
Untriaged or negative image: https://flutter-gold.skia.org/detail?grouping=name%3Dengine.impeller_Play_AiksTest_DrawAdvancedBlendPartlyOffscreen_OpenGLES%26source_type%3Dflutter&digest=665f613c79e86e339ff86d15d950c1b4
stderr: Test: engine.impeller_Play_AiksTest_DrawAdvancedBlendPartlyOffscreen_OpenGLES FAIL
Failed to add image to Skia Gold: Error when running Skia Gold: /Volumes/Work/s/w/ir/cache/gold/goldctl imgtest add --work-dir /Volumes/Work/s/w/ir/x/t/impeller_goldenhw3btb_i/temp --test-name engine.impeller_Play_AiksTest_DrawAdvancedBlendPartlyOffscreen_Metal --png-file /Volumes/Work/s/w/ir/x/t/impeller_goldenhw3btb_i/impeller_Play_AiksTest_DrawAdvancedBlendPartlyOffscreen_Metal.png --passfail --add-test-optional-key image_matching_algorithm:fuzzy --add-test-optional-key fuzzy_max_different_pixels:7864 --add-test-optional-key fuzzy_pixel_delta_threshold:8
Skia Gold received an unapproved image in post-submit
testing. Golden file images in flutter/engine are triaged
in pre-submit during code review for the given PR.
Visit https://flutter-gold.skia.org// to view and approve
the image(s), or revert the associated change. For more
information, visit the wiki:
https://github.com/flutter/flutter/wiki/Writing-a-golden-file-test-for-package:flutter
stdout: Given image with hash 0fc0aaf8dc3239130aad7396c9e2f4a8 for test engine.impeller_Play_AiksTest_DrawAdvancedBlendPartlyOffscreen_Metal
Expectation for test: e2010d7b17e9fa191642e31c73724186 (positive)
Fetching most recent positive digest for trace with ID "e75115180d362d4de7423aeae77bef01".
Non-exact image comparison using algorithm "fuzzy" against most recent positive digest "e2010d7b17e9fa191642e31c73724186".
Untriaged or negative image: https://flutter-gold.skia.org/detail?grouping=name%3Dengine.impeller_Play_AiksTest_DrawAdvancedBlendPartlyOffscreen_Metal%26source_type%3Dflutter&digest=0fc0aaf8dc3239130aad7396c9e2f4a8
stderr: Test: engine.impeller_Play_AiksTest_DrawAdvancedBlendPartlyOffscreen_Metal FAIL
Unhandled exception:
Failed comparison: impeller_Play_AiksTest_CanRenderDifferentShapesWithSameColorSource_Metal.png
#0 harvest.<anonymous closure> (package:golden_tests_harvester/golden_tests_harvester.dart:191:11)
#1 _FutureListener.handleError (dart:async/future_impl.dart:243:22)
#2 Future._propagateToListeners.handleError (dart:async/future_impl.dart:960:47)
#3 Future._propagateToListeners (dart:async/future_impl.dart:981:13)
#4 Future._completeErrorObject (dart:async/future_impl.dart:738:5)
#5 Future._completeError (dart:async/future_impl.dart:742:5)
<asynchronous suspension>
Metadata
Metadata
Assignees
Labels
High-priority issues at the top of the work listHigh-priority issues at the top of the work listflutter/engine repository. See also e: labels.flutter/engine repository. See also e: labels.Building on or for macOS specificallyBuilding on or for macOS specificallyOwned by iOS platform teamOwned by iOS platform teamTriaged by iOS platform teamTriaged by iOS platform team