Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit e0633eb

Browse filesBrowse files
committed
Add debugOverridePlatformViewRegistry to HtmlElementView test.
1 parent d3170f4 commit e0633eb
Copy full SHA for e0633eb

File tree

Expand file treeCollapse file tree

2 files changed

+3
-13
lines changed
Filter options
Expand file treeCollapse file tree

2 files changed

+3
-13
lines changed

‎packages/flutter/lib/src/widgets/_html_element_view_web.dart

Copy file name to clipboardExpand all lines: packages/flutter/lib/src/widgets/_html_element_view_web.dart
+1-9Lines changed: 1 addition & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,7 @@ PlatformViewCreatedCallback? _createPlatformViewCallbackForElementCallback(
7878
return null;
7979
}
8080
return (int id) {
81-
onElementCreated(_platformViewsRegistry.getViewById(id));
81+
onElementCreated(ui_web.platformViewRegistry.getViewById(id));
8282
};
8383
}
8484

@@ -126,11 +126,3 @@ class _HtmlElementViewController extends PlatformViewController {
126126
}
127127
}
128128
}
129-
130-
/// Overrides the [ui_web.PlatformViewRegistry] used by [HtmlElementView].
131-
///
132-
/// This is used for testing view factory registration.
133-
@visibleForTesting
134-
ui_web.PlatformViewRegistry? debugOverridePlatformViewRegistry;
135-
ui_web.PlatformViewRegistry get _platformViewsRegistry =>
136-
debugOverridePlatformViewRegistry ?? ui_web.platformViewRegistry;

‎packages/flutter/test/widgets/html_element_view_test.dart

Copy file name to clipboardExpand all lines: packages/flutter/test/widgets/html_element_view_test.dart
+2-4Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,6 @@ import 'dart:ui_web' as ui_web;
1010

1111
import 'package:flutter/rendering.dart';
1212
import 'package:flutter/services.dart';
13-
import 'package:flutter/src/widgets/_html_element_view_web.dart'
14-
show debugOverridePlatformViewRegistry;
1513
import 'package:flutter/widgets.dart';
1614
import 'package:flutter_test/flutter_test.dart';
1715
import 'package:web/web.dart' as web;
@@ -269,11 +267,11 @@ void main() {
269267

270268
group('HtmlElementView.fromTagName', () {
271269
setUp(() {
272-
debugOverridePlatformViewRegistry = fakePlatformViewRegistry;
270+
ui_web.debugOverridePlatformViewRegistry(fakePlatformViewRegistry);
273271
});
274272

275273
tearDown(() {
276-
debugOverridePlatformViewRegistry = null;
274+
ui_web.debugOverridePlatformViewRegistry(null);
277275
});
278276

279277
testWidgets('Create platform view from tagName', (WidgetTester tester) async {

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.