Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Improve MicrosoftBuildLogger. #1905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 5, 2024
Merged

Improve MicrosoftBuildLogger. #1905

merged 2 commits into from
Oct 5, 2024

Conversation

teo-tsirpanis
Copy link
Contributor

This PR:

  • Makes code more concise.
  • Fixes IsEnabled returning wrong results for errors and warnings if informational messages are disabled.
  • Fixes compatibility with MSBuild versions prior to 17, by handling the LogsMessagesOfImportance method not existing.

@jzabroski jzabroski merged commit a8985e0 into fluentmigrator:main Oct 5, 2024
@teo-tsirpanis teo-tsirpanis deleted the fix-msbuild-logger branch October 5, 2024 12:05
@jzabroski jzabroski added this to the 6.3.0 milestone Oct 5, 2024
@jzabroski
Copy link
Collaborator

Thank you! If you're ever in Boston, look me up!

@jzabroski jzabroski modified the milestones: 6.3.0, 7.0.0 Mar 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
7.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@teo-tsirpanis @jzabroski
Morty Proxy This is a proxified and sanitized view of the page, visit original site.