-
Notifications
You must be signed in to change notification settings - Fork 17
add api extensions #13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add api extensions #13
Conversation
@SoftwareWizard apologies for the delay in reviewing this - i've been a bit busy with the covid-19 response at the NHS here in the UK over the past couple of weeks. I try and have a look over the weekend. |
Thanks a lot Kevin 👍
Holen Sie sich Outlook für iOS
On Thu, Apr 9, 2020 at 7:10 PM +0200, "Kevin Kuszyk" <notifications@github.com> wrote:
@SoftwareWizard apologies for the delay in reviewing this - i've been a bit busy with the covid-19 response at the NHS here in the UK over the past couple of weeks.
I try and have a look over the weekend.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
Hy @SoftwareWizard, Previously I also added some new stuff and I'm planned to add more, but wow you plowed through these features like a king. Nice work! :) |
tests/FluentAssertions.AspNetCore.Mvc.Tests/PhysicalFileResultAssertions_Tests.cs
Show resolved
Hide resolved
I put my questions in the code. |
@SoftwareWizard thanks for bearing with me. I'm a little out of the loop with all things MVC these days. Thanks for the contribution - there's a lot there. @SoftwareWizard @faddiv have you finished your discussion and are you both happy with the changes as is? If yes, I'll merge and ship it. |
Hi Kevin,I am happy so far.May I suggest, that you merge the pull request and give @faddiv the Chance for some improvements.
Kind regards,Simon
Holen Sie sich Outlook für iOS
On Tue, Apr 21, 2020 at 7:05 PM +0200, "Kevin Kuszyk" <notifications@github.com> wrote:
@SoftwareWizard thanks for bearing with me.
I'm a little out of the loop with all things MVC these days. Thanks for the contribution - there's a lot there.
@SoftwareWizard @faddiv have you finished your discussion and are you both happy with the changes as is? If yes, I'll merge and ship it.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
I'm also happy with the changes and I will send my improvements after the merge. |
@SoftwareWizard @faddiv thanks - it's in 2.4 which should be up on nuget shortly. |
extend VirtualFileResultAssertions
extend PhysicalFileResultAssertions
implement CreatedAtRouteResultAssertions
implement CreatedAtActionResultAssertions
implement AcceptedAtRouteResultAssertions
implement AcceptedAtActionResultAssertions
implement LocalRedirectResultAssertions
implement SignIntResultAssertions
implement SignOutResultAssertions
implement UnauthorizedResultAssertions
implement NotFoundResultAssertions
implement NoContentResultAssertions
implement ForbidResultAssertions
implement AcceptedResultAssertions
implement ChallengeResultAssertions
implement CreatedResultAssertions
implement BadRequestResultAssertions
implement OkObjectResultAssertions
implement OkResultAssertions