Skip to content

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

emit() does not call handleError on exception. #172

Copy link
Copy link
Open
@klarose

Description

@klarose
Issue body actions

The documentation for the handleError function of logging.Handler implies that exceptions should be caught by emit and handled by invoking handleError. This allows the environment to customer how logging errors are handled.

The fluent logger Handler does not do this:

data = self.format(record)

The net result is that exceptions triggered when running the fluent logger (either in format or otherwise) are raised, as opposed to log, which is inconsistent with the rest of the logging Handlers.

The fluent logger should call handleError.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      Morty Proxy This is a proxified and sanitized view of the page, visit original site.