Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Called the buffer_overflow_handler at close() #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 23, 2017
Merged

Called the buffer_overflow_handler at close() #19

merged 1 commit into from
Mar 23, 2017

Conversation

yoheimuta
Copy link
Contributor

@yoheimuta yoheimuta commented Dec 24, 2016 •
edited
Loading

ref. https://github.com/fluent/fluent-logger-ruby/blob/77a423c22dbe32f7f4cba0b5a5f94acbdfe9438d/lib/fluent/logger/fluent_logger.rb#L112

  • I want to handle the remaining internal buffer of messages when logger.close() failed flushing.
  • This behavior is compatible with fluent-logger-ruby.

@yoheimuta
Copy link
Contributor Author

Hello, how about that?

@fujiwara fujiwara merged commit 0fd8ca8 into fluent:master Mar 23, 2017
@fujiwara
Copy link
Member

Sorry, I've missed this PR. v0.21 released. Thanks!

@yoheimuta yoheimuta deleted the call-buffer_overflow_handler-at-close branch March 23, 2017 02:08
@yoheimuta
Copy link
Contributor Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yoheimuta @fujiwara
Morty Proxy This is a proxified and sanitized view of the page, visit original site.