Added fluent-logger-ruby compatible buffer_overflow_handler. #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current(master) implementation do nothing when the fluentd buffer was reached on buffer_limit. |
|
Thanks. I merge this PR, and I will add some changes for compatibility. |
fujiwara
added a commit
that referenced
this pull request
Dec 21, 2016
Changelog diff is: diff --git a/Changes b/Changes index fa200d3..c704ad5 100644 --- a/Changes +++ b/Changes @@ -2,6 +2,10 @@ Revision history for Fluent::Logger {{$NEXT}} +0.19 2016-12-21T08:44:55Z + * Added fluent-logger-ruby compatible buffer_overflow_handler (#17 tokuhirom) + * Added truncate_buffer_at_overflow option (#18) + 0.18 2016-06-02T05:52:34Z * Support Sub-second time (for Fluentd 0.14 or later)
fujiwara
added a commit
that referenced
this pull request
Mar 1, 2017
Changelog diff is: diff --git a/Changes b/Changes index c704ad5..0048935 100644 --- a/Changes +++ b/Changes @@ -2,6 +2,9 @@ Revision history for Fluent::Logger {{$NEXT}} +0.20 2017-03-01T04:36:41Z + * Fix tests only which broken with Fluentd 0.14 (#20 #21) + 0.19 2016-12-21T08:44:55Z * Added fluent-logger-ruby compatible buffer_overflow_handler (#17 tokuhirom) * Added truncate_buffer_at_overflow option (#18)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref. https://github.com/fluent/fluent-logger-ruby/blob/c94649a8468f17d1059de4809111399a935f7269/lib/fluent/logger/fluent_logger.rb#L172-L176