Qt: Refresh Spark address book after activation height skips#1831
Open
cursor[bot] wants to merge 3 commits intomasterfiroorg/firo:masterfrom
cursor/critical-bug-inspection-d55dfiroorg/firo:cursor/critical-bug-inspection-d55dCopy head branch name to clipboard
Open
Qt: Refresh Spark address book after activation height skips#1831cursor[bot] wants to merge 3 commits intomasterfiroorg/firo:masterfrom cursor/critical-bug-inspection-d55dfiroorg/firo:cursor/critical-bug-inspection-d55dCopy head branch name to clipboard
cursor[bot] wants to merge 3 commits intomasterfiroorg/firo:masterfrom
cursor/critical-bug-inspection-d55dfiroorg/firo:cursor/critical-bug-inspection-d55dCopy head branch name to clipboard
Conversation
Co-authored-by: Reuben Yap <reuben@firo.org>
Co-authored-by: Reuben Yap <reuben@firo.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR intention
Fix a Spark activation GUI refresh bug where the address book refresh only ran when the GUI observed exactly
nSparkStartBlock. During initial block download, block-tip UI notifications are throttled, so the GUI can jump from below Spark activation to above it without ever receiving the exact activation height. In that case, Spark/Spark-name address-book options may remain unavailable until restart.Code changes brief
nSparkStartBlock, instead of only at exact equality.WalletFrame::updateAddressbook()so multi-wallet sessions do not leave inactive wallet views stale.Validation:
git diff --checkpassed. No reusablebuild/directory was present in the workspace for a targeted Qt build.