refactor(loadtest): remove goose
#11204
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes the goose load testing framework and replaces it with a lightweight custom HTTP load testing implementation. The refactor aims to simplify dependencies and provide more direct control over the load testing logic, but introduces several critical functional regressions.
Key Changes
- Removed
gooseandgumdropdependencies, replacing Goose-based load testing with a custom tokio-based implementation - Simplified HTTP test configuration from duration/user-based to connection-based model
- Removed metrics collection and reporting functionality that previously provided quantitative test results
Reviewed changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 10 comments.
Show a summary per file
| File | Description |
|---|---|
| rust/tests/loadtest/src/http.rs | Complete rewrite of HTTP load testing: removed goose integration, implemented custom connection-based testing with reqwest, eliminated metrics collection |
| rust/tests/loadtest/src/main.rs | Updated TestSelector::resolve_http to use simplified connection-based config instead of duration/users |
| rust/tests/loadtest/src/config.rs | Changed HttpConfig from users/run_time ranges to single max_connections value |
| rust/tests/loadtest/loadtest.example.toml | Updated example config to reflect new connection-based parameters |
| rust/tests/loadtest/Cargo.toml | Removed goose and gumdrop dependencies |
| rust/Cargo.lock | Removed transitive dependencies from goose/gumdrop, updated reqwest to 0.12.26 |
| rust/deny.toml | Cleaned up version skips that were only needed for goose dependency conflicts |
59d9e68 to
76f4e56
Compare
This was referenced Dec 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of pulling in all of
goose, we can instead make HTTP calls ourselves usingreqwest. In later iterations, we can then extend this by e.g. crawling the host further if the response istext/html. For now, a single request per host is enough.Resolves: #11130