[self-host] fix: Add fallback for sitemap discovery due to Fire-engine limited access
#2273
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gaurav Chadha <gauravchadha1676@gmail.com>
Signed-off-by: Gaurav Chadha <gauravchadha1676@gmail.com>
|
This is just a workaround, not to display empty results, although a long-term permanent solution is to extend Fire-engine's capabilities. |
|
Well, this is an issue on self-hosting only, no? Then a fix is to simply not use |
Right only for self-host, I think, then I'll just update this thing in the docs, but won't we be adding support to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: #1397 (comment)
tested OK:
Summary by cubic
Add sitemap fallback in /map for self-hosted setups when Fire Engine isn’t available, preventing empty results. If search finds nothing and sitemap=skip, we now try sitemap discovery and log the outcome.