Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

fix(auth): Fix iOSBundleId parameter name #727

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

jesuslosada
Copy link
Contributor

Fix the iOSBundleId parameter name: #726

@google-cla
Copy link

google-cla bot commented Oct 3, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@jesuslosada jesuslosada force-pushed the fix-ios-bundle-id-parameter branch from 4ee51f4 to c186626 Compare October 3, 2023 14:18
@lahirumaramba lahirumaramba self-requested a review October 4, 2023 16:10
@lahirumaramba lahirumaramba self-assigned this Oct 4, 2023
@lahirumaramba lahirumaramba changed the title Fix iOSBundleId parameter name fix(auth): Fix iOSBundleId parameter name Dec 19, 2023
Copy link
Member

@lahirumaramba lahirumaramba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you for the fix!

@lahirumaramba lahirumaramba merged commit e2ddedb into firebase:master Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.