Return the RequestResponse instead of just awaiting and discarding #2792
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he response's data here contains data of the created Task which is vital for identifying purposes like deleting the task later, it makes no sense to just discard, and is different to what occurs with the cloud task library.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The response's data here contains data of the created Task which is vital for identifying purposes like deleting the task later, it makes no sense to just discard, and is different to what occurs with the cloud task library.
I opened a discussion about this: #2791
But, after being extremely blocked by this issue, I remade the client for local tests, and confirmed that just returning the request gives everything needed.
Testing
All tests passed.