Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Commit f771587

Browse filesBrowse files
jstasiakjstasiak
committed
Provide and enforce type hints everywhere except for tests
The tests' time will come too in the future, though, I think. I believe nose has problems with running annotated tests right now so let's leave it for later. DNSEntry.to_string renamed to entry_to_string because DNSRecord subclasses DNSEntry and overrides to_string with a different signature, so just to be explicit and obvious here I renamed it – I don't think any client code will break because of this. I got rid of ServicePropertiesType in favor of generic Dict because having to type all the properties got annoying when variance got involved – maybe it'll be restored in the future but it seems like too much hassle now.
1 parent 5986bf6 commit f771587
Copy full SHA for f771587

File tree

Expand file treeCollapse file tree

3 files changed

+164
-134
lines changed
Filter options
Expand file treeCollapse file tree

3 files changed

+164
-134
lines changed

‎setup.cfg

Copy file name to clipboardExpand all lines: setup.cfg
+3Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,4 +17,7 @@ warn_unused_ignores = true
1717
warn_return_any = true
1818
# TODO: disallow untyped calls and defs once we have full type hint coverage
1919
disallow_untyped_calls = false
20+
disallow_untyped_defs = true
21+
22+
[mypy-zeroconf.test]
2023
disallow_untyped_defs = false

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.