Set referrerpolicy attribute according to official embed code #52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthiask
approved these changes
Oct 30, 2025
Member
matthiask
left a comment
There was a problem hiding this comment.
Looks good, tests have to be updated though.
Collaborator
Author
|
Oh shit, of course! |
bb62827 to
24a6936
Compare
Collaborator
Author
|
Now with updated tests. |
Member
I don't see them :-( |
24a6936 to
3f00e5d
Compare
Collaborator
Author
|
geez... sorry for that. |
Member
|
No problems, thank you :-) release incoming! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@matthiask This resolves a phenomenon that occurs only for specific domains and with certain browser versions, where YouTube embeds cannot be initialized due to error 153:
I can't find any concrete indication that this is required, but official embed codes provided by YouTube include it this way and it reliably resolved the issue for me where I was able to reproduce it.