Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Consider moving regions modules into django-content-editor application #15

Copy link
Copy link
@bkfox

Description

@bkfox
Issue body actions

Regions class is useful for people not using feincms3 too. Since the regions module does not use any of the feincms3's modules, and offers functionalities directly linked and relevant to django-content-editor, it makes sense to move it there. It would also reduce dependencies when no other feincms3 functionalities are used.

This implies that TemplatePluginRenderer.plugins() method to be moved to PluginRenderer. Also, PluginRenderer is initialized with Model registered which causes troubles when trying to pass down plugin_renderers' plugins as:

contents = contents_for_item(page, page_renderer._renderers.keys())

(this provides an error: type object 'Model' has no attribute 'get_queryset', in contents.py in contents_for_items, line 70). This is solved by removing Model from renderer's plugins.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      Morty Proxy This is a proxified and sanitized view of the page, visit original site.