Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

docs: from-custom page translated into Korean #752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 28, 2025

Conversation

Gaic4o
Copy link
Contributor

@Gaic4o Gaic4o commented Nov 8, 2024

Background

We translated the Using with form-custom page.

If you think there are aspects that need improvement, please let me know, and I would be happy to make the adjustments. Thank you!

I have requested a Korean translation review from one reviewer in the FSD Discord Korean community to ensure that my Korean writing is well done. I would appreciate it if you could merge it after the review is completed.

Copy link

netlify bot commented Nov 8, 2024

👷 Deploy request for pr-fsd accepted.

Name Link
🔨 Latest commit 5d1cdd4
🔍 Latest deploy log https://app.netlify.com/sites/pr-fsd/deploys/672e3d8bdcd74800093a96c6

@Gaic4o
Copy link
Contributor Author

Gaic4o commented Jan 8, 2025

Hello @illright, it’s been over a month now and it seems like no one has reviewed the PRs yet. Would you be able to merge the Korean documentation PRs? If there’s anything that needs to be updated after merging, I can open another PR then. What do you think?

@illright
Copy link
Member

illright commented Jan 8, 2025

Good point, I'll find some time to review them to the best of my abilities, we can always correct later

@Gaic4o
Copy link
Contributor Author

Gaic4o commented Jan 28, 2025

Hello @illright

It has been about three weeks since you commented that you would review this PR. I understand that you must be very busy. During this time, I have thoroughly reviewed this PR and all the other Korean document PRs I submitted, making updates and ensuring everything is as complete as possible.

Would it be possible for you to review and merge this PR, along with the other Korean document PRs I have submitted?

Thank you so much for your time and consideration! 😊

Copy link
Member

@illright illright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for being so patient! It's ready to be merged :)

@illright illright merged commit f62d33e into feature-sliced:master Jan 28, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.