Skip to content

Navigation Menu

Sign in

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Refactor/naming #550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Feb 27, 2023
Merged

Refactor/naming #550

merged 12 commits into from
Feb 27, 2023

Conversation

xxtereshko
Copy link
Contributor

Background

Changelog

See diff.

@netlify
Copy link

netlify bot commented Jan 24, 2023 •
edited
Loading

✅ Deploy Preview for pr-sliced ready!

Name Link
🔨 Latest commit 02400cc
🔍 Latest deploy log https://app.netlify.com/sites/pr-sliced/deploys/63f75277f75aaf0007a5cc66
😎 Deploy Preview https://deploy-preview-550--pr-sliced.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

illright
illright reviewed Jan 29, 2023
View reviewed changes
Copy link
Member

@illright illright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

praise: great job improving the language!

However, while we're at it, I think it's useful to tear this page apart and cut the crap. I've left a few suggestions about it

i18n/en/docusaurus-plugin-content-docs/current/about/understanding/naming.md Outdated Show resolved Hide resolved
i18n/en/docusaurus-plugin-content-docs/current/about/understanding/naming.md Outdated Show resolved Hide resolved
i18n/en/docusaurus-plugin-content-docs/current/about/understanding/naming.md Outdated Show resolved Hide resolved
i18n/en/docusaurus-plugin-content-docs/current/about/understanding/naming.md Outdated Show resolved Hide resolved
i18n/en/docusaurus-plugin-content-docs/current/about/understanding/naming.md Outdated Show resolved Hide resolved
i18n/en/docusaurus-plugin-content-docs/current/about/understanding/naming.md Outdated Show resolved Hide resolved
@azinit
Copy link
Member

azinit commented Feb 10, 2023

@xxtereshko ping

@xxtereshko xxtereshko requested review from illright and removed request for skrylnikov, sandrig and unordinarity February 18, 2023 23:25
@xxtereshko @illright
Update i18n/en/docusaurus-plugin-content-docs/current/about/understan…
2325b24 
…ding/naming.md

Co-authored-by: Lev Chelyadinov <leva181777@gmail.com>
@azinit
Copy link
Member

azinit commented Feb 20, 2023 •
edited
Loading

@illright I suppose we should merge this PR after fixes, without next code-review iterations 🙂
image

@azinit azinit requested a review from illright February 23, 2023 13:43
@azinit
Copy link
Member

azinit commented Feb 24, 2023

@illright is it ready for merge?

azinit
azinit approved these changes Feb 27, 2023
View reviewed changes
Copy link
Member

@azinit azinit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx for contribution and attention for remarks! ❤️

@azinit
Copy link
Member

azinit commented Feb 27, 2023

All remarks are resolved, PR is ready for merge

@illright FYI

@azinit azinit merged commit 6c2f009 into feature-sliced:master Feb 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@azinit azinit azinit approved these changes

@illright illright Awaiting requested review from illright

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xxtereshko @azinit @illright
Morty Proxy This is a proxified and sanitized view of the page, visit original site.