feat: expose 'paramsToAdapter' method#390
Closed
fratzinger wants to merge 1 commit intofeathersjs-ecosystem:masterfeathersjs-ecosystem/feathers-sequelize:masterfrom
fratzinger:params-to-adapterfratzinger/feathers-sequelize:params-to-adapterCopy head branch name to clipboard
Closed
feat: expose 'paramsToAdapter' method#390fratzinger wants to merge 1 commit intofeathersjs-ecosystem:masterfeathersjs-ecosystem/feathers-sequelize:masterfrom fratzinger:params-to-adapterfratzinger/feathers-sequelize:params-to-adapterCopy head branch name to clipboard
fratzinger wants to merge 1 commit intofeathersjs-ecosystem:masterfeathersjs-ecosystem/feathers-sequelize:masterfrom
fratzinger:params-to-adapterfratzinger/feathers-sequelize:params-to-adapterCopy head branch name to clipboard
Conversation
Contributor
|
I like this 👍 . I would like to see this be a pattern on more adapters too. I like that it's a function that defines the relationship between the service method and the adapter method. Params in, adapter method config out. I wonder if |
Closed
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a refactor which exposes a new
paramsToAdapterfunction. It's purpose is to transform feathers params to asequelizequery and have that available from the outside. It's useful for nativesequelizefunctions, likemin,max,sum,incrementanddecrement(see https://sequelize.org/docs/v6/core-concepts/model-querying-basics/#utility-methods).So it's not a breaking change and doesn't change much for existing use cases but it opens up some opportunities. The tests for utility functions are just some use cases.