Dove Support#368
Dove Support#368forgot wants to merge 10 commits intofeathersjs-ecosystem:masterfeathersjs-ecosystem/feathers-sequelize:masterfrom
Conversation
|
Great, thank you for doing that! I'm wondering if I should move the |
|
I'm happy to pull the changes in if you do. Out of curiosity, what was the reason for moving it in the first place? |
|
Well, the type isn't really something a core Feathers service expects or uses, it's only a convention used by the adapters. I just published |
|
I've bumped everything to |
All tests passing
|
I've bumped everything to 5.0.0-pre.9, and all tests are still passing. |
|
This is good to know. At least updating the adapters (other than infrastructure) should be doable then. I had to make a bunch of dud pre-releases because the publish was broken so I didn't expect too much to change. |
# Conflicts: # package-lock.json # package.json
Per deprecation warning: "A boolean value was passed to options.operatorsAliases. This is a no-op with v5 and should be removed."
All tests passing
|
I've bumped everything to 5.0.0-pre.16, and all tests are still passing. |
|
merged via #400 into master. |
Updates
@feathersjsdependencies to^5.0.0-pre.3to work with DoveNot that I could find
Nope!
This pull request primarily updates the type expectations to match Dove. It would obviously be better for this to remain it's own branch and did not merge with
master, but there is not currently a Dove branch.All tests pass with
npm test