Use internal methods instead of service methods directly#13
Merged
daffl merged 1 commit intomasterfeathersjs-ecosystem/feathers-sequelize:masterfrom Jan 30, 2016
internal-methodsfeathersjs-ecosystem/feathers-sequelize:internal-methodsCopy head branch name to clipboard
Merged
Use internal methods instead of service methods directly#13daffl merged 1 commit intomasterfeathersjs-ecosystem/feathers-sequelize:masterfrom internal-methodsfeathersjs-ecosystem/feathers-sequelize:internal-methodsCopy head branch name to clipboard
daffl merged 1 commit intomasterfeathersjs-ecosystem/feathers-sequelize:masterfrom
internal-methodsfeathersjs-ecosystem/feathers-sequelize:internal-methodsCopy head branch name to clipboard
Conversation
daffl
added a commit
that referenced
this pull request
Jan 30, 2016
Use internal methods instead of service methods directly
This was referenced Jan 30, 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is for feathersjs/feathers#218. Basically, if an adapter uses its own service methods internally (like doing a
getafter removing an item) they can't be the original service methods (likeget,create,findetc.) directly since those can be modified by Feathers with mixins and hooks and we do not want those to run in that case.For this adapter we now provide an internal
_get(also see #7),_find(that ignores pagination) and_getOrFind(for patch and remove many).