-
Notifications
You must be signed in to change notification settings - Fork 75
Closed
Description
I noticed this while making this comment: feathersjs/feathers#2472 (comment)
I believe we are potentially wasting some calls to _getOrFind if the user is using $returning: false. Note here:
feathers-sequelize/lib/index.js
Line 222 in db4b5ff
| const ids = this._getOrFind(id, idParams).then(result => { |
that we are fetching the
idList so that the modified results can be returned. But, we don't know for certain that the results need to be returned until feathers-sequelize/lib/index.js
Line 245 in db4b5ff
| if (params.$returning !== false) { |
We should move some code around so that we are not fetching the idList until we check if params.$returning !== false. The _remove method does this. So we should update patch to work similarly.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels