Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Optimize multi patch when $returning is false. #382

Copy link
Copy link
@DaddyWarbucks

Description

@DaddyWarbucks
Issue body actions

I noticed this while making this comment: feathersjs/feathers#2472 (comment)

I believe we are potentially wasting some calls to _getOrFind if the user is using $returning: false. Note here:

const ids = this._getOrFind(id, idParams).then(result => {

that we are fetching the idList so that the modified results can be returned. But, we don't know for certain that the results need to be returned until
if (params.$returning !== false) {

We should move some code around so that we are not fetching the idList until we check if params.$returning !== false. The _remove method does this. So we should update patch to work similarly.

Reactions are currently unavailable

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      Morty Proxy This is a proxified and sanitized view of the page, visit original site.