port to ts#663
Merged
fratzinger merged 35 commits intomasterfeathersjs-ecosystem/feathers-hooks-common:masterfrom May 22, 2022
Merged
port to ts#663fratzinger merged 35 commits intomasterfeathersjs-ecosystem/feathers-hooks-common:masterfrom
fratzinger merged 35 commits intomasterfeathersjs-ecosystem/feathers-hooks-common:masterfrom
Conversation
Co-authored-by: ts-migrate <>
Co-authored-by: ts-migrate <>
Co-authored-by: ts-migrate <>
- `existsByDot` and `data[name]` do basically the same. So `data[name]` is unnecessary
Closed
This was referenced May 22, 2022
Closed
Closed
Collaborator
Author
|
released as |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
continuing from original PR: #654
This is just a plain port to typescript. Just a refactor, nothing should break but imports from
require(feathers-hooks-common/lib/...)orrequire(feathers-hooks-common/types)Strategy: Make it a major version, just to be sure. Release it as premajor first.
Issues: closes #656
PRs: closes #662, #646, #634, #661, #658, #655, #652, #650, #647, #644
Next steps: